[ https://issues.apache.org/jira/browse/HBASE-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146816#comment-13146816 ]
jirapos...@reviews.apache.org commented on HBASE-4554: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2350/ ----------------------------------------------------------- (Updated 2011-11-09 07:01:14.224310) Review request for hbase and Gary Helmling. Changes ------- Minor update by Ted's comments. Summary ------- Features: - Support adding table level coprocessors -- regionobserver and endpoint -- from shell. - Support removing table attributes from shell. Introduced shell comands: hbase> alter 't1', METHOD => 'table_att', \ 'coprocessor'=>'|org.apache.hadoop.hbase.coprocessor.SimpleRegionObserver||' coprocessor$1 => 'hdfs:///foo.jar|com.sample.foo|1' will be added to htd. So that cp framework can load the cp later on. hbase> alter 't1', METHOD => 'table_att_unset', NAME => 'MAX_FILESIZE' hbase> alter 't1', METHOD => 'table_att_unset', NAME => 'coprocessor$1' This addresses bug HBASE-4554. https://issues.apache.org/jira/browse/HBASE-4554 Diffs (updated) ----- src/main/java/org/apache/hadoop/hbase/HConstants.java 76278a2 src/main/ruby/hbase/admin.rb 61e04d8 src/main/ruby/shell/commands/alter.rb ee3668d src/test/ruby/hbase/admin_test.rb df88100 Diff: https://reviews.apache.org/r/2350/diff Testing ------- Test passed after applied HBase-4555 patch locally. Thanks, Mingjie > Allow set/unset coprocessor table attributes from shell. > -------------------------------------------------------- > > Key: HBASE-4554 > URL: https://issues.apache.org/jira/browse/HBASE-4554 > Project: HBase > Issue Type: Improvement > Components: coprocessors > Reporter: Mingjie Lai > Assignee: Mingjie Lai > Fix For: 0.92.0 > > > Table/region level coprocessor -- RegionObserver -- can be configured by > setting a HTD's attribute which matches Coprocessor$*. > Current shell -- alter -- cannot support to set/unset a table's arbitrary > attribute. We need it in order to configure region level coprocessors to a > table. > Proposed new shell: > {code} > hbase shell > alter 't1', METHOD => 'table_att', COPROCESSOR$1 => > 'hdfs://cp/foo.jar|org.apache.hadoop.hbase.sample|1|' > hbase shell > describe 't1' > {NAME => 't1', COPROCESSOR$1 => > 'hdfs://cp/foo.jar|org.apache.hadoop.hbase.sample|1|', MAX_FILESIZE => > '134217728', ...} > hbase shell > alter 't1', METHOD => 'table_att_unset', COPROCESSOR$1 > hbase shell > describe 't1' > {NAME => 't1', MAX_FILESIZE => '134217728', ...} > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira