[ https://issues.apache.org/jira/browse/HBASE-13839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147992#comment-15147992 ]
stack commented on HBASE-13839: ------------------------------- Yeah, this broke TestMasterStatusServlet. Paging limit no longer supported. A bit of paging [~mwarhaftig] when you get a chance? Keeping the change because its nice improvement. Applied addendum to the test. The coded added here doesn't go the mocked path the test takes anymore. Fixed it. > Fix AssgnmentManagerTmpl.jamon issues (coloring, content etc.) > -------------------------------------------------------------- > > Key: HBASE-13839 > URL: https://issues.apache.org/jira/browse/HBASE-13839 > Project: HBase > Issue Type: Bug > Components: master, UI > Affects Versions: 1.1.0 > Reporter: Lars George > Assignee: Matt Warhaftig > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-13838_post.tiff, HBASE-13838_pre.tiff, > hbase-13839-v1.patch > > > The template for the RIT in the Master status page, > AssignmentManagerTmpl.jamon) has a few issues: > - The oldest RIT should not be _red_, looks like a failed entry > The RIT entries should be for example yellow/amber when over the threshold > time, and red if 2x the threshold - or red for the oldest once over the > threshold. > - Region count over RIT threshold should only be colored if > 0 > The summary line (first of two) should not be colored unless there is a value > > 0 in it. > - Color is overriden by table-stripped CSS style! > The Bootstrap stylesheet cancels out the hardcoded coloring! The > table-stripped resets the conditional coloring and should be fixed. Best is > to use "alert-warning" etc. that come from the Bootstrap theme stylesheet. > That should maybe already work in combination with the "table-stripped" from > the same. > - Should sort descending by time > Currently the list of regions is sorted by encoded region name. Better is to > have the table sorted by RIT time descending. > We should also think about a pagination option for the currently hardcoded > 100 entries max. Maybe a separate issue? -- This message was sent by Atlassian JIRA (v6.3.4#6332)