[ 
https://issues.apache.org/jira/browse/HBASE-15338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169245#comment-15169245
 ] 

Anoop Sam John commented on HBASE-15338:
----------------------------------------

For data block cache on write, we have a global config.  In case of cache on 
read no global config.  There is no issue in adding one.  +1 on that.

+        conf.getBoolean(CACHE_DATA_ON_READ_KEY, DEFAULT_CACHE_DATA_ON_READ)
+           && family.isBlockCacheEnabled(),

For other configs we have || condition btw global one and family specific.  Why 
this is different?   There was one issue with this discussion. I forgot which 
issue and whether we have closed that or not.

> Add a option to disable the data block cache for testing the performance of 
> underlying file system
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15338
>                 URL: https://issues.apache.org/jira/browse/HBASE-15338
>             Project: HBase
>          Issue Type: Improvement
>          Components: integration tests
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15338-trunk-v1.diff, HBASE-15338-trunk-v2.diff, 
> HBASE-15338-trunk-v3.diff, HBASE-15338-trunk-v4.diff, 
> HBASE-15338-trunk-v5.diff, HBASE-15338-trunk-v6.diff
>
>
> When testing and comparing the performance of different file systems(HDFS, 
> Azure blob storage, AWS S3 and so on) for HBase, it's better to avoid the 
> affect of the HBase BlockCache and get the actually random read latency when 
> data block is read from underlying file system. (Usually, the index block and 
> meta block should be cached in memory in the testing).
> So we add a option in CacheConfig to disable the data block cache.
> Suggestions are welcomed~ Thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to