[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4628: ------------------------------- Attachment: HBASE-4628.D417.1.patch cgist requested code review of "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell". Reviewers: nspiegelberg, JIRA [89-fb] HBase shell can pre-split a new table at creation THis change adds optional arguments to the HBase shell's create command to split a tabel into a specified number of regions using a specified splitting algorithm as defined by RegionSplitter. Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. TEST PLAN Created tables with and without splits using the shell; also attempted to give incorrect arguments to shell create command. REVISION DETAIL https://reviews.facebook.net/D417 AFFECTED FILES src/main/ruby/hbase.rb src/main/ruby/hbase/admin.rb src/main/ruby/shell/commands/create.rb MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/837/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. > Enhance Table Create Presplit Functionality within the HBase Shell > ------------------------------------------------------------------ > > Key: HBASE-4628 > URL: https://issues.apache.org/jira/browse/HBASE-4628 > Project: HBase > Issue Type: Improvement > Reporter: Nicolas Spiegelberg > Assignee: Nicolas Spiegelberg > Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch > > > Currently, we allow the user to presplit in the HBase shell by explicitly > listing the startkey of all the region shards that they want. Instead, we > should provide the RegionSplitter functionality of choosing a split > algorithm, followed by the number of splits that they want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira