[
https://issues.apache.org/jira/browse/HBASE-15366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175044#comment-15175044
]
ramkrishna.s.vasudevan commented on HBASE-15366:
------------------------------------------------
Overall patch looks great. +1
> Add doc, trace-level logging, and test around hfileblock
> --------------------------------------------------------
>
> Key: HBASE-15366
> URL: https://issues.apache.org/jira/browse/HBASE-15366
> Project: HBase
> Issue Type: Sub-task
> Components: BlockCache
> Affects Versions: 2.0.0
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0
>
> Attachments: 15366.patch, 15366v2.patch, 15366v3.patch, 15366v4.patch
>
>
> What hfileblock is doing -- that it overreads when pulling in from hdfs to
> fetch the header of the next block to save on seeks; that it caches the block
> and overread and then adds an extra 13 bytes to the cached entry; that
> buckets in bucketcache have at least four hfileblocks in them and so on --
> was totally baffling me. This patch docs the class, adds some trace-level
> logging so you can see if you are doing the right thing, and then adds a test
> of file-backed bucketcache that checks that persistence is working.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
