[
https://issues.apache.org/jira/browse/HBASE-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182376#comment-15182376
]
Lars Hofhansl commented on HBASE-15243:
---------------------------------------
Looks good to me.
As for the observation above:
bq. This might be tangential but I think seeking could be a bit more aggressive
on the MUST_PASS_ALL case as well.
I'd agree. We only have to reverse the compare the getHint method and we'll
find the optimize (i.e. max) hint value for MUST_PASS_ALL. Different jira maybe.
I will say the FilterList is more tricky than it should and we've seen many
"funny" things with in the past. The more tests we have the better.
> Utilize the lowest seek value when all Filters in MUST_PASS_ONE FilterList
> return SEEK_NEXT_USING_HINT
> ------------------------------------------------------------------------------------------------------
>
> Key: HBASE-15243
> URL: https://issues.apache.org/jira/browse/HBASE-15243
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-15243-v1.txt, HBASE-15243-v2.txt,
> HBASE-15243-v3.txt, HBASE-15243-v4.txt, HBASE-15243-v5.txt,
> HBASE-15243-v6.txt, HBASE-15243-v7.txt
>
>
> As Preston Koprivica pointed out at the tail of HBASE-4394, when all filters
> in a MUST_PASS_ONE FilterList return a SEEK_USING_NEXT_HINT code, we should
> return SEEK_NEXT_USING_HINT from the FilterList to utilize the lowest seek
> value.
> This would save unnecessary accesses to blocks which are not in scan result.
> A unit test has been added which shows the reduction in the number of blocks
> accessed when this optimization takes effect.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
