[ 
https://issues.apache.org/jira/browse/HBASE-15377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184655#comment-15184655
 ] 

Hadoop QA commented on HBASE-15377:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 33s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
23s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 52s 
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 53s 
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
10s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 
52s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 33s 
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 54s 
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 55s 
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 55s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 57s 
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 57s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 6s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m 5s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 22s 
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 53s 
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 29s 
{color} | {color:green} hbase-hadoop-compat in the patch passed with JDK 
v1.8.0. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 30s 
{color} | {color:green} hbase-hadoop-compat in the patch passed with JDK 
v1.8.0. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 34s 
{color} | {color:green} hbase-hadoop2-compat in the patch passed with JDK 
v1.8.0. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 23s 
{color} | {color:green} hbase-hadoop2-compat in the patch passed with JDK 
v1.8.0. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 21m 4s {color} 
| {color:red} hbase-server in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 20m 46s {color} 
| {color:red} hbase-server in the patch failed with JDK v1.8.0. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 20s 
{color} | {color:green} hbase-hadoop-compat in the patch passed with JDK 
v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 19s 
{color} | {color:green} hbase-hadoop-compat in the patch passed with JDK 
v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 26s 
{color} | {color:green} hbase-hadoop2-compat in the patch passed with JDK 
v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 26s 
{color} | {color:green} hbase-hadoop2-compat in the patch passed with JDK 
v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 21m 56s {color} 
| {color:red} hbase-server in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 23m 4s {color} 
| {color:red} hbase-server in the patch failed with JDK v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
51s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 162m 54s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0 Failed junit tests | 
hadoop.hbase.regionserver.TestMetricsRegionServer |
|   | hadoop.hbase.regionserver.TestMetricsRegionServer |
| JDK v1.7.0_79 Failed junit tests | 
hadoop.hbase.regionserver.TestMetricsRegionServer |
|   | hadoop.hbase.regionserver.TestMetricsRegionServer |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12791926/HBASE-15377.patch |
| JIRA Issue | HBASE-15377 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux asf910.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / 46cc3d4 |
| Default Java | 1.7.0_79 |
| Multi-JDK versions |  /home/jenkins/tools/java/jdk1.8.0:1.8.0 
/usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 |
| findbugs | v3.0.0 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/886/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/886/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/886/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_79.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/886/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_79.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-HBASE-Build/886/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt
 
https://builds.apache.org/job/PreCommit-HBASE-Build/886/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt
 
https://builds.apache.org/job/PreCommit-HBASE-Build/886/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_79.txt
 
https://builds.apache.org/job/PreCommit-HBASE-Build/886/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_79.txt
 |
| JDK v1.7.0_79  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/886/testReport/ |
| modules | C:  hbase-hadoop-compat   hbase-hadoop-compat   
hbase-hadoop2-compat   hbase-hadoop2-compat   hbase-server   hbase-server  U: . 
|
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/886/console |
| Powered by | Apache Yetus 0.2.0   http://yetus.apache.org |


This message was automatically generated.



> Per-RS Get metric is time based, per-region metric is size-based
> ----------------------------------------------------------------
>
>                 Key: HBASE-15377
>                 URL: https://issues.apache.org/jira/browse/HBASE-15377
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Heng Chen
>             Fix For: 2.0.0, 1.3.0, 1.4.0
>
>         Attachments: HBASE-15377.patch
>
>
> We have metrics for Get operations at the region server level and region 
> level. 
> {code}
>    "Get_num_ops" : 4837505,
>     "Get_min" : 0,
>     "Get_max" : 296,
>     "Get_mean" : 0.2934618155433431,
>     "Get_median" : 0.0,
>     "Get_75th_percentile" : 0.0,
>     "Get_95th_percentile" : 1.0,
>     "Get_99th_percentile" : 1.0,
> {code}
> and 
> {code}
>    "Namespace_hbase_table_meta_region_1588230740_metric_get_num_ops" : 103,
>     "Namespace_hbase_table_meta_region_1588230740_metric_get_min" : 450,
>     "Namespace_hbase_table_meta_region_1588230740_metric_get_max" : 470,
>     "Namespace_hbase_table_meta_region_1588230740_metric_get_mean" : 
> 450.19417475728153,
>     "Namespace_hbase_table_meta_region_1588230740_metric_get_median" : 460.0,
>     "Namespace_hbase_table_meta_region_1588230740_metric_get_75th_percentile" 
> : 470.0,
>     "Namespace_hbase_table_meta_region_1588230740_metric_get_95th_percentile" 
> : 470.0,
>     "Namespace_hbase_table_meta_region_1588230740_metric_get_99th_percentile" 
> : 470.0,
> {code}
> The problem is that the report values for the region server shows the 
> latency, versus the reported values for the region shows the response sizes. 
> There is no way of telling this without reading the source code. 
> I think we should deprecate response size histograms in favor of latency 
> histograms. 
> See also HBASE-15376. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to