[
https://issues.apache.org/jira/browse/HBASE-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149696#comment-13149696
]
Hadoop QA commented on HBASE-4780:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12503610/4780_trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -163 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 50 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestRollingRestart
org.apache.hadoop.hbase.client.TestMultiParallel
org.apache.hadoop.hbase.client.TestScannerTimeout
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
org.apache.hadoop.hbase.replication.TestReplication
org.apache.hadoop.hbase.catalog.TestMetaReaderEditor
org.apache.hadoop.hbase.TestFullLogReconstruction
org.apache.hadoop.hbase.TestZooKeeper
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/242//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/242//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/242//console
This message is automatically generated.
> Lower mini cluster shutdown time in HRegionServer#waitOnAllRegionsToClose and
> ServerManager#letRegionServersShutdown
> --------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4780
> URL: https://issues.apache.org/jira/browse/HBASE-4780
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver, test
> Affects Versions: 0.94.0
> Environment: all
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 4780_trunk.patch, 4780_trunk.patch
>
>
> HRegionServer#waitOnAllRegionsToClose sleep 1s
> Lower waiting time
> benefits: around 0.8s at shutdown
> ServerManager.letRegionServersShutdown() waits 1 second => responsible for
> 0.5 seconds in a HBase cluster stops
> Can be replaced by a notification
> Benefits: around 0.5s at shutdown
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
