[ https://issues.apache.org/jira/browse/HBASE-15464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199127#comment-15199127 ]
Elliott Clark commented on HBASE-15464: --------------------------------------- * Need to fix the TestHeapSize * Why the changes around throughput controller? TestStripeStoreEngine etc. * Dead store in find bugs seems legit. * Everything else looks good. > Flush / Compaction metrics revisited > ------------------------------------ > > Key: HBASE-15464 > URL: https://issues.apache.org/jira/browse/HBASE-15464 > Project: HBase > Issue Type: Sub-task > Components: metrics > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: hbase-15464_v1.patch, hbase-15464_v2.patch > > > We can add a couple of metrics related to flushes and compactions: > - flush memstore and output file size histogram: This will allow seeing > whether we are flushing too early due to memory pressure, too many regions, > etc. Tracking flush memstore size vs output file size is useful in > understanding the block encoding compression benefits. > - total flushed output bytes: This will allow to monitor the IO / throughput > from flushers. You can use this to set num flushers, flush throttle, etc. > - smallCompactionQueueLength / large...: This is tracked, but not emitted > anymore due to a bug. > - compaction time histogram: similar to flush time histogram, how long > compactions are taking. > - compaction input num files / output num files histogram: How many files on > average we are compacting. Stripe compaction / date tiered compaction can use > the num output files metric. > - compaction input / output data sizes histogram: How much data on average > we are compacting. > - compaction input / output total bytes: Measure compaction IO / throughput. > measure write amplification, enables to set compaction throttle. > - Breakdown for above for major compactions -- This message was sent by Atlassian JIRA (v6.3.4#6332)