[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199101#comment-15199101 ]
Hadoop QA commented on HBASE-15456: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s {color} | {color:red} HBASE-15456 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.2.0/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12793852/HBASE-15456-001_branch-1.patch | | JIRA Issue | HBASE-15456 | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1041/console | | Powered by | Apache Yetus 0.2.0 http://yetus.apache.org | This message was automatically generated. > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --------------------------------------------------------------------------------------------------- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master > Affects Versions: 2.0.0 > Reporter: huaxiang sun > Assignee: huaxiang sun > Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, HBASE-15456-v001.patch, > HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)