[ https://issues.apache.org/jira/browse/HBASE-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203037#comment-15203037 ]
Hadoop QA commented on HBASE-15474: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s {color} | {color:red} HBASE-15474 does not apply to branch-1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.2.0/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12794381/HBASE-15474-branch-1.v3.patch | | JIRA Issue | HBASE-15474 | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1091/console | | Powered by | Apache Yetus 0.2.0 http://yetus.apache.org | This message was automatically generated. > Exception in HConnectionImplementation's constructor cause Zookeeper > connnections leak > --------------------------------------------------------------------------------------- > > Key: HBASE-15474 > URL: https://issues.apache.org/jira/browse/HBASE-15474 > Project: HBase > Issue Type: Bug > Affects Versions: 1.1.0 > Reporter: Allan Yang > Assignee: Allan Yang > Labels: patch > Fix For: 1.1.0 > > Attachments: HBASE-15474-branch-1.v3.patch, HBASE-15474v2.patch > > > HConnectionImplementation creates a ZooKeeperKeepAliveConnection during > construction, but if the constructor throw a exception, the zookeeper > connection is not properly closed. > {code} > HConnectionImplementation(Configuration conf, boolean managed, > ExecutorService pool, User user) throws IOException { > this(conf); > this.user = user; > this.batchPool = pool; > this.managed = managed; > this.registry = setupRegistry(); > retrieveClusterId(); //here is the zookeeper connection created > this.rpcClient = RpcClientFactory.createClient(this.conf, > this.clusterId);// In our case, the exception happens here, so the zookeeper > connection never closes > this.rpcControllerFactory = RpcControllerFactory.instantiate(conf); > ...... > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)