[ https://issues.apache.org/jira/browse/HBASE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150170#comment-13150170 ]
Hadoop QA commented on HBASE-4764: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12503694/4764_trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 10 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -163 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 51 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestDistributedLogSplitting Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/248//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/248//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/248//console This message is automatically generated. > naming errors for TestHLogUtils and SoftValueSortedMapTest > ---------------------------------------------------------- > > Key: HBASE-4764 > URL: https://issues.apache.org/jira/browse/HBASE-4764 > Project: HBase > Issue Type: Improvement > Components: test > Affects Versions: 0.94.0 > Reporter: nkeywal > Assignee: nkeywal > Priority: Minor > Attachments: 4764_trunk.patch, 4764_trunk.patch > > > SoftValueSortedMapTest it's a test, but not a junit one, I tend to think it's > not called. I don't know if it's used. > TestHLogUtils has a wrong name: it's not a test, but an helper. It confuses > the script looking for the tests. It would seems a better thing to rename it. > Is there anything special to do to keep the history attached to this file? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira