[ 
https://issues.apache.org/jira/browse/HBASE-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220341#comment-15220341
 ] 

Walter Koetke commented on HBASE-15556:
---------------------------------------

Sure, Sean, your concern is understood. I can start a discussion on dev@ but in 
the meantime, this might help: It is not so much that we needed a significantly 
different implementation. Rather, we just found we were able to improve 
performance bottlenecks by replacing synchronized code with usage of 
ConcurrentHashMap and AtomicLong. I'm attaching our 'custom' implementation 
class (SIMultiVersionConsistencyControl) so you can see what we mean. It seemed 
'safer' to make it pluggable but maybe it's cleaner just to propose our changes 
go directly into the MultiVersionConsistencyControl class. What do you think?

> need extensible ConsistencyControl interface
> --------------------------------------------
>
>                 Key: HBASE-15556
>                 URL: https://issues.apache.org/jira/browse/HBASE-15556
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 1.0.3
>            Reporter: Walter Koetke
>            Assignee: Walter Koetke
>             Fix For: 1.0.4
>
>         Attachments: HBASE-15556-branch-1.0-02.patch, 
> HBASE-15556-branch-1.0.patch
>
>
> The class MultiVersionConsistencyControl should be abstracted into an 
> interface ConsistencyControl so it can be extended by a configured custom 
> implementation class, with MultiVersionConsistencyControl as the default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to