[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221270#comment-15221270
]
Anoop Sam John edited comment on HBASE-14921 at 4/1/16 7:30 AM:
----------------------------------------------------------------
[~anastas]
I read the new classes in this patch. So in which patch this is being used ?
Or it will come later?
I see there are 2 sets of MSLAB chunks in place now
In one the actual cell bytes are present (Key + Value)
In second set of chunks (CellBlockSerialized.java) we have 3 ints per Cell
serialized.
One suggestion- We dont need the last int of Cell length. We have the offset
to Cell.. And there we are serializing as how The KV structure looks like. So
we can read the key len and value len and sum it to get the cell total length.
See constructor - KeyValue(final byte [] bytes, final int offset)
So what other structure we have? CellBlockObjectArray where used?
In CellBlockSerialized#getCellFromIndex(int i) how we get the index to be
passed?
was (Author: anoop.hbase):
[~anastas]
I read the new classes in this patch. So in which patch this is being used ?
Or it will come later?
I see there are 2 sets of MSLAB chunks in place now
In one the actual cell bytes are present (Key + Value)
In second set of chunks (CellBlockSerialized.java) we have 3 ints per Cell
serialized.
One suggestion- We dont need the last int of Cell length. We have the offset
to Cell.. And there we are serializing as how The KV structure looks like. So
we can read the key len and value len and sum it to get the cell total length.
So what other structure we have? CellBlockObjectArray where used?
In CellBlockSerialized#getCellFromIndex(int i) how we get the index to be
passed?
> Memory optimizations
> --------------------
>
> Key: HBASE-14921
> URL: https://issues.apache.org/jira/browse/HBASE-14921
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Eshcar Hillel
> Assignee: Anastasia Braginsky
> Attachments: CellBlocksSegmentInMemStore.pdf,
> CellBlocksSegmentinthecontextofMemStore(1).pdf, HBASE-14921-V01.patch,
> HBASE-14921-V02.patch
>
>
> Memory optimizations including compressed format representation and offheap
> allocations
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
