[ 
https://issues.apache.org/jira/browse/HBASE-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151143#comment-13151143
 ] 

gaojinchao commented on HBASE-4654:
-----------------------------------

Do we need throw exceptin in api "addPeer"? 
                
> [replication] Add a check to make sure we don't replicate to ourselves
> ----------------------------------------------------------------------
>
>                 Key: HBASE-4654
>                 URL: https://issues.apache.org/jira/browse/HBASE-4654
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.4
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.90.5
>
>         Attachments: 4654-trunk.txt
>
>
> It's currently possible to add a peer for replication and point it to the 
> local cluster, which I believe could very well happen for those like us that 
> use only one ZK ensemble per DC so that only the root znode changes when you 
> want to set up replication intra-DC.
> I don't think comparing just the cluster ID would be enough because you would 
> normally use a different one for another cluster and nothing will block you 
> from pointing elsewhere.
> Comparing the ZK ensemble address doesn't work either when you have multiple 
> DNS entries that point at the same place.
> I think this could be resolved by looking up the master address in the 
> relevant znode as it should be exactly the same thing in the case where you 
> have the same cluster.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to