[ https://issues.apache.org/jira/browse/HBASE-15405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236406#comment-15236406 ]
Hadoop QA commented on HBASE-15405: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 13s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 42s {color} | {color:green} master passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s {color} | {color:green} master passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m 43s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 55s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s {color} | {color:green} master passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s {color} | {color:green} master passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 42s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 39s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 39s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 33s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m 38s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 26m 1s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 12s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 96m 12s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 145m 18s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12798137/HBASE-15405-master-v5.patch | | JIRA Issue | HBASE-15405 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux pietas.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 8964573 | | Default Java | 1.7.0_79 | | Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/1363/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/1363/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1363/console | | Powered by | Apache Yetus 0.2.1 http://yetus.apache.org | This message was automatically generated. > Fix PE logging and wrong defaults in help message > ------------------------------------------------- > > Key: HBASE-15405 > URL: https://issues.apache.org/jira/browse/HBASE-15405 > Project: HBase > Issue Type: Bug > Components: Performance > Reporter: Appy > Assignee: Appy > Priority: Minor > Attachments: HBASE-15405-master-v2.patch, > HBASE-15405-master-v3.patch, HBASE-15405-master-v4 (1).patch, > HBASE-15405-master-v4 (1).patch, HBASE-15405-master-v4.patch, > HBASE-15405-master-v4.patch, HBASE-15405-master-v5.patch, > HBASE-15405-master.patch, HBASE-15405-master.patch > > > Corrects wrong default values for few options in the help message. > Final stats from multiple clients are intermingled making it hard to > understand. Also the logged stats aren't very machine readable. It can be > helpful in a daily perf testing rig which scraps logs for results. > Example of logs before the change. > {noformat} > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest latency log > (microseconds), on 1048576 measures > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest latency log > (microseconds), on 1048576 measures > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest latency log > (microseconds), on 1048576 measures > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest latency log > (microseconds), on 1048576 measures > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest latency log > (microseconds), on 1048576 measures > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest latency log > (microseconds), on 1048576 measures > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest latency log > (microseconds), on 1048576 measures > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: 0/1048570/1048576, > latency mean=953.98, min=359.00, max=324050.00, stdDev=851.82, 95th=1368.00, > 99th=1625.00 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: 0/1048570/1048576, > latency mean=953.92, min=356.00, max=323394.00, stdDev=817.55, 95th=1370.00, > 99th=1618.00 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: 0/1048570/1048576, > latency mean=953.98, min=367.00, max=322745.00, stdDev=840.43, 95th=1369.00, > 99th=1622.00 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest latency log > (microseconds), on 1048576 measures > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest latency log > (microseconds), on 1048576 measures > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest latency log > (microseconds), on 1048576 measures > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest Min = > 375.0 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest Min = > 363.0 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest Avg = > 953.6624126434326 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest Avg = > 953.4124526977539 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest StdDev = > 781.3929776087633 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest StdDev = > 742.8027916717297 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 50th = > 894.0 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 50th = > 894.0 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 75th = > 1070.0 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 75th = > 1071.0 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 95th = > 1369.0 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 95th = > 1369.0 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 99th = > 1623.0 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 99th = > 1624.0 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest Min = > 372.0 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 99.9th = > 3013.9980000000214 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest Avg = > 953.2451229095459 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 99.9th = > 3043.9980000000214 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest StdDev = > 725.4744472152282 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 99.99th = > 25282.380199996755 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 50th = > 895.0 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 99.99th = > 25812.763399994 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 75th = > 1071.0 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 99.999th = > 89772.78990004538 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 95th = > 1369.0 > 16/03/05 22:43:06 INFO hbase.PerformanceEvaluation: IncrementTest 99.999th = > 122808.39587019826 > {noformat} > After the change > {noformat} > 16/03/06 02:38:21 INFO hbase.PerformanceEvaluation: Test : RandomWriteTest, > Thread : TestClient-1 > 16/03/06 02:38:21 INFO hbase.PerformanceEvaluation: Latency (us) : , > mean=6.23, min=2.00, max=101433.00, stdDev=246.62, 50th=2.00, 75th=2.00, > 95th=3.00, 99th=13.00, 99.9th=558.00, 99.99th=9656.19, 99.999th=20213.63 > 16/03/06 02:38:21 INFO hbase.PerformanceEvaluation: Num measures (latency) : > 1048576 > 16/03/06 02:38:21 INFO hbase.PerformanceEvaluation: ValueSize (bytes) : , > mean=0.00, min=0.00, max=0.00, stdDev=0.00, 50th=0.00, 75th=0.00, 95th=0.00, > 99th=0.00, 99.9th=0.00, 99.99th=0.00, 99.999th=0.00 > 16/03/06 02:38:21 INFO hbase.PerformanceEvaluation: Num measures (ValueSize): > 0 > ... > 16/03/06 02:38:21 INFO hbase.PerformanceEvaluation: Test : RandomWriteTest, > Thread : TestClient-0 > 16/03/06 02:38:21 INFO hbase.PerformanceEvaluation: Latency (us) : , > mean=6.23, min=1.00, max=99321.00, stdDev=246.41, 50th=2.00, 75th=2.00, > 95th=3.00, 99th=13.00, 99.9th=566.00, 99.99th=9694.60, 99.999th=23311.86 > .... > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)