[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151654#comment-13151654
]
jirapos...@reviews.apache.org commented on HBASE-4213:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/#review3307
-----------------------------------------------------------
Looks good to me now (I admit, I only browsed over the new tracker code).
/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
<https://reviews.apache.org/r/1786/#comment7392>
This is no longer the case.
/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<https://reviews.apache.org/r/1786/#comment7394>
It also might not return the current list of all online regions, as
onlineRegions is changed by other callers (like the one above) without a lock.
Is that a problem here?
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
<https://reviews.apache.org/r/1786/#comment7395>
Super minor nit: Make this string just once?
- Lars
On 2011-11-16 19:12:03, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1786/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-16 19:12:03)
bq.
bq.
bq. Review request for Todd Lipcon, Andrew Purtell and Subbu Iyer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. From Subbu:
bq. here is the latest patch that support alter_instant, an instant schema
change command that supports (Add, Modify, Delete column and Modify table)
actions through ZK.
bq.
bq. 1. This pattern capitalizes on the fact that HRI's are now in HDFS and
need not be sent over again from Master to RS cloud on every schema change
event.
bq.
bq. 2. Offers real time instant schema change as we bypass the explicit bulk
reassign (unassign + assign) of regions from master to RS.
bq.
bq. 3. Offers fault tolerant schema change support as schema changes now go
through ZK. Secondary master taking over a failed schema change will be
addressed through a separate JIRA.
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1202381
bq. /src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
1202381
bq. /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1202381
bq. /src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
1202381
bq. /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1202381
bq. /src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
1202381
bq. /src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
1202381
bq. /src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1202381
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
1202381
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
1202381
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
1202381
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
1202381
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
1202523
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
1202381
bq.
/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
1202381
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1202381
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java
1202381
bq.
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
PRE-CREATION
bq.
/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
PRE-CREATION
bq. /src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
1202381
bq. /src/main/resources/hbase-default.xml 1202381
bq.
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java
PRE-CREATION
bq.
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
PRE-CREATION
bq. /src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
1202381
bq.
/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java
1202381
bq.
bq. Diff: https://reviews.apache.org/r/1786/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> Support for fault tolerant, instant schema updates with out master's
> intervention (i.e with out enable/disable and bulk assign/unassign) through
> ZK.
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4213
> URL: https://issues.apache.org/jira/browse/HBASE-4213
> Project: HBase
> Issue Type: Improvement
> Reporter: Subbu M Iyer
> Assignee: Subbu M Iyer
> Fix For: 0.94.0
>
> Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4,
> 4213-101211-Support_instant_schema_changes_through_ZK.patch,
> 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch,
> 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch,
> 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch,
> 4213-V10-Support_instant_schema_changes_through_ZK.patch,
> 4213-V5-Support_instant_schema_changes_through_ZK.patch,
> 4213-V7-Support_instant_schema_changes_through_ZK.patch,
> 4213-V8-Support_instant_schema_changes_through_ZK.patch,
> 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk.txt,
> 4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch,
> HBASE-4213_Instant_schema_change_-Version_2_.patch,
> HBASE_Instant_schema_change-version_3_.patch
>
>
> This Jira is a slight variation in approach to what is being done as part of
> https://issues.apache.org/jira/browse/HBASE-1730
> Support instant schema updates such as Modify Table, Add Column, Modify
> Column operations:
> 1. With out enable/disabling the table.
> 2. With out bulk unassign/assign of regions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
