[ https://issues.apache.org/jira/browse/HBASE-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249219#comment-15249219 ]
stack commented on HBASE-15645: ------------------------------- [~yangzhe1991] I think this patch looks really good. Does it work? Do we timeout after operation timeout has elapsed? What you think [~Apache9]? [~mantonov] You like this boss? Looks good to me. Big change but I'd be +1. One thought I was having was if we should be able to set rpc timeout on the Connection. Nice. > hbase.rpc.timeout is not used in operations of HTable > ----------------------------------------------------- > > Key: HBASE-15645 > URL: https://issues.apache.org/jira/browse/HBASE-15645 > Project: HBase > Issue Type: Bug > Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4 > Reporter: Phil Yang > Assignee: Phil Yang > Priority: Critical > Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2 > > Attachments: HBASE-15645-v1.patch, HBASE-15645-v2.patch, > HBASE-15645-v3.patch, HBASE-15645-v4.patch > > > While fixing HBASE-15593, I find that we use operationTimeout as the timeout > of Get operation rpc call (hbase.client.scanner.timeout.period is used in > scan rpc), not the hbase.rpc.timeout. > This can be verified by add one line in TestHCM.setUpBeforeClass(): > {code} > TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000); > {code} > and then run testOperationTimeout(), the test passes but it should have > failed because we should get rpc timeout first after 3 seconds then client > should retry and timeout again and again until operationTimeout or max > retries reached. > If I port this test to 0.98, it will fail as expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)