[jira] [Commented] (HBASE-15368) Add pluggable window support

[Duo Zhang (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-15368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249704#comment-15249704
 ] 

Duo Zhang commented on HBASE-15368:
-----------------------------------

For the branch-1 result

{noformat}
java.lang.AssertionError: expected:<0> but was:<1>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:645)
        at org.junit.Assert.assertEquals(Assert.java:631)
        at 
org.apache.hadoop.hbase.regionserver.TestHRegion.testWritesWhileGetting(TestHRegion.java:4084)
{noformat}

I think this is not related to our patch here but seems a critical bug?

{code}
          for (Cell kv : result.rawCells()) {
            byte[] thisValue = CellUtil.cloneValue(kv);
            if (previousKV != null) {
              if (Bytes.compareTo(CellUtil.cloneValue(previousKV), thisValue) 
!= 0) {
                LOG.warn("These two KV should have the same value." + " 
Previous KV:" + previousKV
                    + "(memStoreTS:" + previousKV.getMvccVersion() + ")" + ", 
New KV: " + kv
                    + "(memStoreTS:" + kv.getMvccVersion() + ")");
                assertEquals(0, 
Bytes.compareTo(CellUtil.cloneValue(previousKV), thisValue)); // <=== error on 
this line
              }
            }
            previousKV = kv;
          }
{code}

But I haven't found the warning log message... Really strange...

https://builds.apache.org/job/PreCommit-HBASE-Build/1507/testReport/org.apache.hadoop.hbase.regionserver/TestHRegion/testWritesWhileGetting/


> Add pluggable window support
> ----------------------------
>
>                 Key: HBASE-15368
>                 URL: https://issues.apache.org/jira/browse/HBASE-15368
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction
>    Affects Versions: 2.0.0, 1.3.0, 0.98.19, 1.4.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0, 1.3.0, 0.98.19, 1.4.0
>
>         Attachments: HBASE-15368-0.98.patch, HBASE-15368-branch-1.patch, 
> HBASE-15368-v1.patch, HBASE-15368-v2.patch, HBASE-15368-v3.patch, 
> HBASE-15368-v4.patch, HBASE-15368-v5.patch, HBASE-15368-v6.patch, 
> HBASE-15368-v7.patch, HBASE-15368.patch
>
>
> Abstract a {{CompactionWindow}} and a {{CompactionWindowFactory}}. Both are 
> orthogonal to the implementation of DateTieredCompactionPolicy. Users can 
> implement their own {{CompactionWindow}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)