[
https://issues.apache.org/jira/browse/HBASE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255365#comment-15255365
]
Ted Yu commented on HBASE-15699:
--------------------------------
lgtm
{code}
425 public void testSyncNoAppend() throws IOException {
{code}
There seems to be no assertion in the above test.
> Can not sync AsyncFSWAL if no edit is appended
> ----------------------------------------------
>
> Key: HBASE-15699
> URL: https://issues.apache.org/jira/browse/HBASE-15699
> Project: HBase
> Issue Type: Bug
> Components: wal
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-15699.patch
>
>
> The problem is the txid that we assign to SyncFuture. In AsyncFSWAL, we will
> assign a zero txid if no edit is append, and it just equals to
> SyncFuture.NOT_DONE, so the sync request will never finish...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
