[ 
https://issues.apache.org/jira/browse/HBASE-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262772#comment-15262772
 ] 

Stephen Yuan Jiang commented on HBASE-6633:
-------------------------------------------

I am not sure better or worse.  I just worry about that someone is using 
postSplit would lost functionality when we remove it in 3.0.  Another thing I 
think is that we should really separate successful and failed split - for now, 
postCompletedSplit is called no matter when it is success or failure.  I think 
in failure situation, postRollbackSplit should take care of it; the 
postCompleteSplit only deal with success situation.

> Adding new hooks to the split flow - For roll backs and one final hook after 
> split is completed either successfully or failed
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-6633
>                 URL: https://issues.apache.org/jira/browse/HBASE-6633
>             Project: HBase
>          Issue Type: Improvement
>          Components: Coprocessors
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>              Labels: coprocessors
>             Fix For: 0.95.0
>
>         Attachments: HBASE-6633.patch
>
>
> Currently we have two hooks in the split flow of a region.  PreSplit() and 
> postSplit().  But not always these are helpful in case i have a problem in 
> preSplit() or postSplit() i need to do a rollback of the current region or 
> the region that i am handling thro the hooks.
> So its better if we have a hook in the rollback code and also one final hook 
> say postCompleteSplit() so that CP can take any corrective action.
> Pls do suggest if i can provide a patch for this.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to