[
https://issues.apache.org/jira/browse/HBASE-15333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265439#comment-15265439
]
Jonathan Hsieh commented on HBASE-15333:
----------------------------------------
I'll review the next draft on reviewboard -- I didn't notice the link on the
first review. Should make this back and forth easier.
1. My concern is less about it being a replacement and more about adding some
explanation about the the multi-phase map/reduce construct. Some of the
response would be really helpful as comments in the code.
4.1/4.2 When you move it to a separate class, it would be good to have the
class name and scaladoc say that it is the naive non-order preserving
encoder/decoder. An example in the class doc highlighting/illustrating why
range union and interests are needed would be super helpful as well.
5. I'm less familiar with this portion -- can you improve the java/scaladoc so
that it is easier for me to understand what this text and this class is used
for?
6. Thanks. I care more about making it readable than the formal scala doc
format but if we can make it easier for future folks to review we should.
7. Thanks. We could even possibly go with 'NaiveBytesEncoder' since the
encoding isn't necessarily java specific.
8. Thanks.
> Enhance the filter to handle short, integer, long, float and double
> -------------------------------------------------------------------
>
> Key: HBASE-15333
> URL: https://issues.apache.org/jira/browse/HBASE-15333
> Project: HBase
> Issue Type: Sub-task
> Reporter: Zhan Zhang
> Assignee: Zhan Zhang
> Attachments: HBASE-15333-1.patch, HBASE-15333-2.patch,
> HBASE-15333-3.patch, HBASE-15333-4.patch, HBASE-15333-5.patch
>
>
> Currently, the range filter is based on the order of bytes. But for java
> primitive type, such as short, int, long, double, float, etc, their order is
> not consistent with their byte order, extra manipulation has to be in place
> to take care of them correctly.
> For example, for the integer range (-100, 100), the filter <= 1, the current
> filter will return 0 and 1, and the right return value should be (-100, 1]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
