[ 
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268737#comment-15268737
 ] 

Anoop Sam John commented on HBASE-14920:
----------------------------------------

bq.None of the counters (RS, region, segment) are new, all of them existed 
before this patch, so I fail to see the problem.
I agree. Am not saying this patch added any..  What I say is with the size math 
happens in 3 places and with added more calls now after this patch to change 
the size, it is very complex.  It is more error prone..  So just asking whether 
we should visit this area and some way simplify it.  Not direct on this patch.

> Compacting Memstore
> -------------------
>
>                 Key: HBASE-14920
>                 URL: https://issues.apache.org/jira/browse/HBASE-14920
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Eshcar Hillel
>            Assignee: Eshcar Hillel
>         Attachments: HBASE-14920-V01.patch, HBASE-14920-V02.patch, 
> HBASE-14920-V03.patch, HBASE-14920-V04.patch, HBASE-14920-V05.patch, 
> HBASE-14920-V06.patch, move.to.junit4.patch
>
>
> Implementation of a new compacting memstore with non-optimized immutable 
> segment representation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to