[ 
https://issues.apache.org/jira/browse/HBASE-15830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284841#comment-15284841
 ] 

Ted Yu commented on HBASE-15830:
--------------------------------

In the patch, I don't see TestAsyncSecureIPC being modified.

I assume you would add new test related to the fix in the next patch.

> Sasl encryption doesn't work with AsyncRpcChannelImpl
> -----------------------------------------------------
>
>                 Key: HBASE-15830
>                 URL: https://issues.apache.org/jira/browse/HBASE-15830
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Colin Ma
>         Attachments: HBASE-15830.001.patch
>
>
> Currently, sasl encryption doesn't work with AsyncRpcChannelImpl, there has 3 
> problems:
> 1. 
> [sourcecode|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslClientHandler.java#L308]
>  will throw the following exception:
> java.lang.UnsupportedOperationException: direct buffer
>       at 
> io.netty.buffer.UnpooledUnsafeDirectByteBuf.array(UnpooledUnsafeDirectByteBuf.java:199)
>       at 
> org.apache.hadoop.hbase.security.SaslClientHandler.write(SaslClientHandler.java:308)
> 2. 
> [sourcecode|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannelImpl.java#L212]
>  has deadlocks problem.
> 3. TestAsyncSecureIPC doesn't cover the sasl encryption test case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to