[ https://issues.apache.org/jira/browse/HBASE-4798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153487#comment-13153487 ]
Hadoop QA commented on HBASE-4798: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12504358/4798_trunk_all.v10.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 21 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 59 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestAdmin org.apache.hadoop.hbase.regionserver.wal.TestLogRolling org.apache.hadoop.hbase.coprocessor.TestMasterObserver org.apache.hadoop.hbase.client.TestShell Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/310//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/310//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/310//console This message is automatically generated. > Sleeps and synchronisation improvements for tests > ------------------------------------------------- > > Key: HBASE-4798 > URL: https://issues.apache.org/jira/browse/HBASE-4798 > Project: HBase > Issue Type: Improvement > Components: master, regionserver, test > Affects Versions: 0.94.0 > Environment: all > Reporter: nkeywal > Assignee: nkeywal > Priority: Minor > Attachments: 4798_trunk_all.v10.patch, 4798_trunk_all.v10.patch, > 4798_trunk_all.v2.patch, 4798_trunk_all.v5.patch, 4798_trunk_all.v6.patch, > 4798_trunk_all.v7.patch > > > Multiple small changes: > @commiters: Removing some sleeps made visible a bug on > JVMClusterUtil#HMaster#waitForServerOnline, so I had to add a synchro point. > You may want to review this. > JVMClusterUtil#HMaster#waitForServerOnline: removed, the condition was never > met (test on "!c && !!c"). Added a new synchronization point. > AssignementManager#waitForAssignment: add a timeout on the wait => not stuck > if the notification is received before the wait. > HMaster#loop: use a notification instead of a 1s sleep > HRegionServer#waitForServerOnline: new method used by > JVMClusterUtil#waitForServerOnline() to replace a 1s sleep by a notification > HRegionServer#getMaster() 1s sleeps replaced by one 0,1s sleep and one 0,2s > sleep > HRegionServer#stop: use a notification on sleeper to lower shutdown by 0,5s > ZooKeeperNodeTracker#start: replace a recursive call by a loop > ZooKeeperNodeTracker#blockUntilAvailable: add a timeout on the wait => not > stuck if the notification is received before the wait. > HBaseTestingUtility#expireSession: use a timeout of 1s instead of 5s > TestZooKeeper#testClientSessionExpired: use a timeout of 1s instead of 5s, > with the change on HBaseTestingUtility we are 60s faster > TestRegionRebalancing#waitForAllRegionsAssigned: use a sleep of 0,2s instead > of 1s > TestRestartCluster#testClusterRestart: send all the table creation together, > then check creation, should be faster > TestHLog: shutdown the whole cluster instead of DFS only (more standard) > JVMClusterUtil#startup: lower the sleep from 1s to 0,1s > HConnectionManager#close: Zookeeper name in debug message from > HConnectionManager after connection close was always null because it was set > to null in the delete. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira