[ https://issues.apache.org/jira/browse/HBASE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292398#comment-15292398 ]
Appy commented on HBASE-15858: ------------------------------ But we had this issue even with that test, right, so it's not sufficient. In fact, this is a general issue in our shell testing. We test that the ruby functions work ( {{hbase.rsgroup_admin(@formatter).get_rsgroup}} in this case) but often do not test the actual commands, which exercise some additional code which lies in in commands/<exact_command>.rb. I would suggest adding a simple test which does this {{@shell.command('get_server_rsgroup', ...)}} and {{@shell.command('get_rsgroup', ...)}} > Some region server group shell commands don't work > -------------------------------------------------- > > Key: HBASE-15858 > URL: https://issues.apache.org/jira/browse/HBASE-15858 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Attachments: 15858.v1.patch, 15858.v2.patch > > > [~cartershanklin] reported the following: > {code} > hbase(main):021:0> get_rsgroup 'test_group' > GROUP INFORMATION > ERROR: undefined local variable or method `group_admin' for > #<Shell::Commands::GetRsgroup:0x33ec2c0c> > Here is some help for this command: > Get a region server group's information. > Example: > hbase> get_rsgroup 'default' > {code} > {code} > hbase(main):009:0> get_server_rsgroup > 'hdp250-hbase-unsecure.example.com:16030' > ERROR: undefined method `getGroupOfServer' for > #<Hbase::RSGroupAdmin:0x251d7fdd> > Here is some help for this command: > Get the group name the given region server is a member of. > hbase> get_server_rsgroup 'server1:port1' > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)