[
https://issues.apache.org/jira/browse/HBASE-15803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305161#comment-15305161
]
stack commented on HBASE-15803:
-------------------------------
What you think of the patch [~ikeda]-san?
> ZooKeeperWatcher's constructor can leak a ZooKeeper instance with throwing
> ZooKeeperConnectionException when canCreateBaseZNode is true
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-15803
> URL: https://issues.apache.org/jira/browse/HBASE-15803
> Project: HBase
> Issue Type: Bug
> Reporter: Hiroshi Ikeda
> Assignee: Ted Yu
> Priority: Minor
> Attachments: 15803.v1.txt
>
>
> {code}
> public ZooKeeperWatcher(Configuration conf, String identifier,
> Abortable abortable, boolean canCreateBaseZNode)
> throws IOException, ZooKeeperConnectionException {
> ...skip...
> this.recoverableZooKeeper = ZKUtil.connect(...
> ...skip...
> if (canCreateBaseZNode) {
> createBaseZNodes();
> }
> }
> private void createBaseZNodes() throws ZooKeeperConnectionException {
> {code}
> The registered watcher doesn't seem to close the Zookeeper instance by watch
> events, and the instance keeps alive when createBaseZNodes is failed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
