[ 
https://issues.apache.org/jira/browse/HBASE-15969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317493#comment-15317493
 ] 

Andrew Purtell commented on HBASE-15969:
----------------------------------------

The check must admit a second valid form:

{noformat}
HBASE-XXXX Single line summary (Contributor attribution)

Optional extended message
{noformat}

No signed-off line. This is what gets committed when a plain patch, not 
something produced by 'git format-patch' is submitted. 

> add precommit check for commit message formating
> ------------------------------------------------
>
>                 Key: HBASE-15969
>                 URL: https://issues.apache.org/jira/browse/HBASE-15969
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Sean Busbey
>
> add a precommit check that sees if commit messages are of the form:
> {code}
> HBASE-XXXXX Single line summary of issues, pref under 76 col
> Optional extended description that might contain pre-existing signed-off by
> entries if e.g. it's a version posted by a reviewer as an update.
> Signed-off-by: Jane Reviewer <jrevie...@example.com>
> {code}
> Open to other things we can easily check for via regex (please add in 
> comments).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to