[ 
https://issues.apache.org/jira/browse/HBASE-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

huaxiang sun updated HBASE-15959:
---------------------------------
    Attachment: HBASE-15959-v004.patch

Upload v3 based on [~jingcheng...@intel.com]'s comment, indeed it is a nicer 
solution as store.close() will move compacted files to archive, please add 
jingcheng's name to the author list, thanks.

> Fix flaky test TestRegionServerMetrics.testMobMetrics
> -----------------------------------------------------
>
>                 Key: HBASE-15959
>                 URL: https://issues.apache.org/jira/browse/HBASE-15959
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: huaxiang sun
>         Attachments: HBASE-15959-v001.patch, HBASE-15959-v002.patch, 
> HBASE-15959-v003.patch, HBASE-15959-v004.patch
>
>
> It flakes 
> [here|https://github.com/apache/hbase/blob/b557f0bec62a48753e5d01d7a47f3c9e5a6b3ee8/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java#L460].
> There are two weird things i identified:
> 1. In second compaction, 
> [scanner|https://github.com/apache/hbase/blob/b557f0bec62a48753e5d01d7a47f3c9e5a6b3ee8/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java#L173]
>  has 10 storefiles. Shouldn't there be 6? 5 from recent flushes and 1 from 
> earlier compaction. Probably because mob cleaner doesn't clean old hfiles. 
> Does this needs fixing?
> 2. Across runs, same cell (ie. same key) may or may not be considered mob 
> reference cell. 
> [here|https://github.com/apache/hbase/blob/b557f0bec62a48753e5d01d7a47f3c9e5a6b3ee8/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java#L213].
>  This at least happens with row keys 0 - 4 (which got compacted earlier). 
> [~jmhsieh] Any ideas why this would happen.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to