[
https://issues.apache.org/jira/browse/HBASE-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325487#comment-15325487
]
Jonathan Hsieh commented on HBASE-15984:
----------------------------------------
Can you add a unit test to exercise this path?
Can we add some metrics to count how many times the different updated
ReplicationSource paths are exercised?
Do the trace calls happen frequently? Would make sense to wrap the cheaper:
{code}
if (LOG.isTraceEnabled()) {
LOG.trace("something with a string concat operation " + op.getvalue())
}
{code}
> Given failure to parse a given WAL that was closed cleanly, replay the WAL.
> ---------------------------------------------------------------------------
>
> Key: HBASE-15984
> URL: https://issues.apache.org/jira/browse/HBASE-15984
> Project: HBase
> Issue Type: Sub-task
> Components: Replication
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.2.2, 1.1.6, 0.98.21
>
> Attachments: HBASE-15984.1.patch
>
>
> subtask for a general work around for "underlying reader failed / is in a bad
> state" just for the case where a WAL 1) was closed cleanly and 2) we can tell
> that our current offset ought not be the end of parseable entries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
