[ https://issues.apache.org/jira/browse/HBASE-4739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155050#comment-13155050 ]
Ted Yu edited comment on HBASE-4739 at 11/22/11 6:05 PM: --------------------------------------------------------- This patch is not compatible, I added M_ZK_REGION_CLOSING and delete RS_ZK_REGION_CLOSING in EventHandler.java. I have another question, Can I delete below code block in function unassign(HRegionInfo region, boolean force) ? {code} } catch (NotServingRegionException nsre) { LOG.info("Server " + server + " returned " + nsre + " for " + region.getEncodedName()); // Presume that master has stale data. Presume remote side just split. // Presume that the split message when it comes in will fix up the master's // in memory cluster state. }catch (Throwable t) {code} I think we should use the wrap of RemoteException. was (Author: sunnygao): This patch is not compatible, I added M_ZK_REGION_CLOSING and delete RS_ZK_REGION_CLOSING in EventHandler.java. I have another question, Can I delete below code block in function unassign(HRegionInfo region, boolean force) ? } catch (NotServingRegionException nsre) { LOG.info("Server " + server + " returned " + nsre + " for " + region.getEncodedName()); // Presume that master has stale data. Presume remote side just split. // Presume that the split message when it comes in will fix up the master's // in memory cluster state. }catch (Throwable t) I think we should use the wrap of RemoteException. > Master dying while going to close a region can leave it in transition forever > ----------------------------------------------------------------------------- > > Key: HBASE-4739 > URL: https://issues.apache.org/jira/browse/HBASE-4739 > Project: HBase > Issue Type: Bug > Affects Versions: 0.90.4 > Reporter: Jean-Daniel Cryans > Assignee: gaojinchao > Priority: Minor > Fix For: 0.92.0, 0.94.0, 0.90.5 > > Attachments: 4739_trial2.patch, 4739_trialV3.patch, > HBASE-4739_Trunk.patch, HBASE-4739_Trunk_V2.patch, HBASE-4739_trail5.patch, > HBASE-4739_trial.patch, HBASE-4739_trial6.patch > > > I saw this in the aftermath of HBASE-4729 on a 0.92 refreshed yesterday, when > the master died it had just created the RIT znode for a region but didn't > tell the RS to close it yet. > When the master restarted it saw the znode and started printing this: > {quote} > 2011-11-03 00:02:49,130 INFO > org.apache.hadoop.hbase.master.AssignmentManager: Regions in transition timed > out: TestTable,0007560564,1320253568406.f76899564cabe7e9857c3aeb526ec9dc. > state=CLOSING, ts=1320253605285, server=sv4r11s38,62003,1320195046948 > 2011-11-03 00:02:49,130 INFO > org.apache.hadoop.hbase.master.AssignmentManager: Region has been CLOSING for > too long, this should eventually complete or the server will expire, doing > nothing > {quote} > It's never going to happen, and it's blocking balancing. > I'm marking this as minor since I believe this situation is pretty rare > unless you hit other bugs while trying out stuff to root bugs out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira