[ https://issues.apache.org/jira/browse/HBASE-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155771#comment-13155771 ]
Hadoop QA commented on HBASE-4853: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12504860/4853-v4.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/346//console This message is automatically generated. > HBASE-4789 does overzealous pruning of seqids > --------------------------------------------- > > Key: HBASE-4853 > URL: https://issues.apache.org/jira/browse/HBASE-4853 > Project: HBase > Issue Type: Bug > Reporter: stack > Priority: Critical > Attachments: 4853--no-prefix.txt, 4853-trunk.txt, 4853-v4.txt, > 4853.txt > > > Working w/ J-D on failing replication test turned up hole in seqids made by > the patch over in hbase-4789. With this patch in place we see lots of > instances of the suspicious: 'Last sequenceid written is empty. Deleting all > old hlogs' > At a minimum, these lines need removing: > {code} > diff --git a/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java > b/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java > index 623edbe..a0bbe01 100644 > --- a/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java > +++ b/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java > @@ -1359,11 +1359,6 @@ public class HLog implements Syncable { > // Cleaning up of lastSeqWritten is in the finally clause because we > // don't want to confuse getOldestOutstandingSeqNum() > this.lastSeqWritten.remove(getSnapshotName(encodedRegionName)); > - Long l = this.lastSeqWritten.remove(encodedRegionName); > - if (l != null) { > - LOG.warn("Why is there a raw encodedRegionName in lastSeqWritten? > name=" + > - Bytes.toString(encodedRegionName) + ", seqid=" + l); > - } > this.cacheFlushLock.unlock(); > } > } > {code} > ... but above is no good w/o figuring why WALs are not being rotated off. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira