[ 
https://issues.apache.org/jira/browse/HBASE-16122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353019#comment-15353019
 ] 

Konstantin Ryakhovskiy commented on HBASE-16122:
------------------------------------------------

patch added: https://reviews.apache.org/r/49316/
added try-catch block and re-throw IllegalArgumentException with more 
user-friendly message.
tests are added
Is the patch appropriate and sufficient?

> PerformanceEvaluation should provide user friendly hint when client threads 
> argument is missing
> -----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16122
>                 URL: https://issues.apache.org/jira/browse/HBASE-16122
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> I tried to run this command:
> hbase pe --rows=10000 --nomapred --valueSize=2000000 sequentialWrite
> {code}
> java.util.NoSuchElementException
>       at java.util.LinkedList.removeFirst(LinkedList.java:270)
>       at java.util.LinkedList.remove(LinkedList.java:685)
>       at 
> org.apache.hadoop.hbase.PerformanceEvaluation.parseOpts(PerformanceEvaluation.java:2077)
>       at 
> org.apache.hadoop.hbase.PerformanceEvaluation.run(PerformanceEvaluation.java:2122)
>       at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
>       at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
>       at 
> org.apache.hadoop.hbase.PerformanceEvaluation.main(PerformanceEvaluation.java:2159)
> {code}
> Number of client threads argument was missing.
> PerformanceEvaluation should print user friendly message informing user of 
> the missing argument.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to