[ 
https://issues.apache.org/jira/browse/HBASE-16129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353452#comment-15353452
 ] 

Dima Spivak commented on HBASE-16129:
-------------------------------------

So I think I'll just do two things here:
- Add the above-mentioned flag to override the Java ACC we pull down from 
GitHub.
- Go ahead and implement the proper XML descriptor creation that newer versions 
of Java ACC require.

The dev mentions performance improvements in the tool in recent versions, so it 
seems worth a few minutes of Bash hacking to do this the right way. Patch 
forthcoming...

> check_compatibility.sh is broken when using Java API Compliance Checker v1.7
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-16129
>                 URL: https://issues.apache.org/jira/browse/HBASE-16129
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: Dima Spivak
>            Assignee: Dima Spivak
>         Attachments: HBASE-16129_v1.patch, HBASE-16129_v2.patch
>
>
> As part of HBASE-16073, we hardcoded check_compatiblity.sh to check out the 
> v1.7 tag of Java ACC. Unfortunately, just running it between two branches 
> that I know have incompatibilities, I get 0 incompatibilities (and 0 classes 
> read). Looks like this version doesn't properly traverse through JARs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to