[ https://issues.apache.org/jira/browse/HBASE-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367384#comment-15367384 ]
Yu Li commented on HBASE-16194: ------------------------------- Yes, the {{CellSkipListSet#add}} method invokes {{Map#put}}, so the value will always be updated, and the returning boolean actually indicates whether there was an old value of the same key, not that straight forward for reading... Let's just leave it as is for now... > Should count in MSLAB chunk allocation into heap size change when adding > duplicated cells > ----------------------------------------------------------------------------------------- > > Key: HBASE-16194 > URL: https://issues.apache.org/jira/browse/HBASE-16194 > Project: HBase > Issue Type: Sub-task > Affects Versions: 1.2.1, 1.1.5, 0.98.20 > Reporter: Yu Li > Assignee: Yu Li > Attachments: HBASE-16194.patch, HBASE-16194_v2.patch > > > See more details about problem description and analysis in HBASE-16193 -- This message was sent by Atlassian JIRA (v6.3.4#6332)