[
https://issues.apache.org/jira/browse/HBASE-16195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370255#comment-15370255
]
ramkrishna.s.vasudevan commented on HBASE-16195:
------------------------------------------------
{code}
// chunk already initialized, so if chunk queue not null, we must remove the
chunk from queue
144 // after retiring it or else it might cause memory leak,
especially when there're lots of
145 // cells with same key
146 if (chunkQueue != null) {
147 chunkQueue.remove(c);
148 }
{code}
This change may not be needed. Associating the chunkQueue with chunkPool is
fine because even while closing and decrementing we try to return back the
chunks in the queue to the pool. When there is no chunkpool then they wil be
simple getting stored without GCing. But this remove() this not needed because
anyway the chunk can be reused I feel.
> Should not add chunk into chunkQueue if not using chunk pool in
> HeapMemStoreLAB
> -------------------------------------------------------------------------------
>
> Key: HBASE-16195
> URL: https://issues.apache.org/jira/browse/HBASE-16195
> Project: HBase
> Issue Type: Sub-task
> Reporter: Yu Li
> Assignee: Yu Li
> Attachments: HBASE-16195.patch, HBASE-16195_v2.patch
>
>
> Problem description and analysis please refer to HBASE-16193
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
