[ https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392872#comment-15392872 ]
Hudson commented on HBASE-16205: -------------------------------- FAILURE: Integrated in HBase-Trunk_matrix #1295 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1295/]) HBASE-16205 When Cells are not copied to MSLAB, deep clone it while (anoopsamjohn: rev 2df0ef549abe0ee8e58d4290193b5d69b3e8d6c6) * hbase-common/src/main/java/org/apache/hadoop/hbase/ShareableMemory.java * hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodecWithTags.java * hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodec.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AbstractMemStore.java > When Cells are not copied to MSLAB, deep clone it while adding to Memstore > -------------------------------------------------------------------------- > > Key: HBASE-16205 > URL: https://issues.apache.org/jira/browse/HBASE-16205 > Project: HBase > Issue Type: Sub-task > Components: regionserver > Affects Versions: 2.0.0 > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-16205.patch, HBASE-16205_V2.patch, > HBASE-16205_V3.patch, HBASE-16205_V3.patch > > > This is imp after HBASE-15180 optimization. After that we the cells flowing > in write path will be backed by the same byte[] where the RPC read the > request into. By default we have MSLAB On and so we have a copy operation > while adding Cells to memstore. This copy might not be there if > 1. MSLAB is turned OFF > 2. Cell size is more than a configurable max size. This defaults to 256 KB > 3. If the operation is Append/Increment. > In such cases, we should just clone the Cell into a new byte[] and then add > to memstore. Or else we keep referring to the bigger byte[] chunk for longer > time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)