[ https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394466#comment-15394466 ]
Hadoop QA commented on HBASE-15638: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 73 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 31s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 8s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 59s {color} | {color:green} master passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 37s {color} | {color:green} master passed with JDK v1.7.0_80 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 30m 27s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 49s {color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 30s {color} | {color:red} hbase-protocol in master has 93 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 45s {color} | {color:red} hbase-rsgroup in master has 6 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 56s {color} | {color:red} hbase-rest in master has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 7s {color} | {color:green} master passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 21s {color} | {color:green} master passed with JDK v1.7.0_80 {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 20s {color} | {color:red} hbase-examples in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 36s {color} | {color:red} hbase-examples in the patch failed with JDK v1.8.0. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 36s {color} | {color:red} hbase-examples in the patch failed with JDK v1.8.0. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 21s {color} | {color:red} hbase-examples in the patch failed with JDK v1.7.0_80. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 20m 33s {color} | {color:red} hbase-common-jdk1.7.0_80 with JDK v1.7.0_80 generated 1 new + 25 unchanged - 1 fixed = 26 total (was 26) {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 21s {color} | {color:red} hbase-examples in the patch failed with JDK v1.7.0_80. {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 32m 44s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 4m 22s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red} The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s {color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 3s {color} | {color:red} Patch causes 83 errors with Hadoop v2.4.0. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 53s {color} | {color:red} Patch causes 83 errors with Hadoop v2.4.1. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m 55s {color} | {color:red} Patch causes 83 errors with Hadoop v2.5.0. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 12m 5s {color} | {color:red} Patch causes 83 errors with Hadoop v2.5.1. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 15m 16s {color} | {color:red} Patch causes 83 errors with Hadoop v2.5.2. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 18m 28s {color} | {color:red} Patch causes 83 errors with Hadoop v2.6.1. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 21m 40s {color} | {color:red} Patch causes 83 errors with Hadoop v2.6.2. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 24m 54s {color} | {color:red} Patch causes 83 errors with Hadoop v2.6.3. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 27m 54s {color} | {color:red} Patch causes 83 errors with Hadoop v2.7.1. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 25s {color} | {color:red} hbase-examples in the patch failed. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 6m 39s {color} | {color:red} hbase-client-jdk1.8.0 with JDK v1.8.0 generated 87 new + 13 unchanged - 0 fixed = 100 total (was 13) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 6m 39s {color} | {color:red} hbase-server-jdk1.8.0 with JDK v1.8.0 generated 6 new + 1 unchanged - 0 fixed = 7 total (was 1) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 6m 39s {color} | {color:red} hbase-examples-jdk1.8.0 with JDK v1.8.0 generated 9 new + 0 unchanged - 0 fixed = 9 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 1s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 10m 31s {color} | {color:red} hbase-client-jdk1.7.0_80 with JDK v1.7.0_80 generated 114 new + 13 unchanged - 0 fixed = 127 total (was 13) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 10m 31s {color} | {color:red} hbase-server-jdk1.7.0_80 with JDK v1.7.0_80 generated 6 new + 1 unchanged - 0 fixed = 7 total (was 1) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 10m 31s {color} | {color:red} hbase-examples-jdk1.7.0_80 with JDK v1.7.0_80 generated 9 new + 0 unchanged - 0 fixed = 9 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 51s {color} | {color:green} the patch passed with JDK v1.7.0_80 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 35s {color} | {color:green} hbase-protocol in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 37s {color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 36s {color} | {color:green} hbase-procedure in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 34s {color} | {color:red} hbase-client in the patch failed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 25m 3s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 35s {color} | {color:green} hbase-rsgroup in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 33s {color} | {color:green} hbase-it in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 26s {color} | {color:red} hbase-examples in the patch failed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 2m 50s {color} | {color:red} hbase-rest in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 8s {color} | {color:green} hbase-spark in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 55s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 229m 12s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.TestInterfaceAudienceAnnotations | | | hadoop.hbase.master.balancer.TestRegionLocationFinder | | | hadoop.hbase.mob.mapreduce.TestMobSweepMapper | | | hadoop.hbase.procedure.TestProcedureManager | | | hadoop.hbase.rest.TestStatusResource | | | hadoop.hbase.rest.TestNamespacesResource | | | hadoop.hbase.rest.TestNamespacesInstanceResource | | | hadoop.hbase.rest.TestGzipFilter | | | hadoop.hbase.rest.TestScannersWithLabels | | | hadoop.hbase.rest.TestSchemaResource | | | hadoop.hbase.rest.TestMultiRowResource | | | hadoop.hbase.rest.TestScannersWithFilters | | | hadoop.hbase.rest.TestTableResource | | | hadoop.hbase.rest.TestResourceFilter | | | hadoop.hbase.rest.TestVersionResource | | | hadoop.hbase.rest.client.TestRemoteTable | | | hadoop.hbase.rest.TestTableScan | | | hadoop.hbase.rest.TestScannerResource | | | hadoop.hbase.rest.TestGetAndPutResource | | | hadoop.hbase.rest.TestDeleteRow | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12820186/HBASE-15638.master.005.patch | | JIRA Issue | HBASE-15638 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux pomona.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / bcf409e | | Default Java | 1.7.0_80 | | Multi-JDK versions | /usr/local/jenkins/java/jdk1.8.0:1.8.0 /home/jenkins/jenkins-slave/tools/hudson.model.JDK/JDK_1.7_latest_:1.7.0_80 | | findbugs | v3.0.0 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/branch-findbugs-hbase-protocol-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/branch-findbugs-hbase-rest-warnings.html | | mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/patch-mvninstall-hbase-examples.txt | | compile | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/patch-compile-hbase-examples-jdk1.8.0.txt | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/patch-compile-hbase-examples-jdk1.8.0.txt | | compile | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/patch-compile-hbase-examples-jdk1.7.0_80.txt | | javac | hbase-common-jdk1.7.0_80: https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/diff-compile-javac-hbase-common-jdk1.7.0_80.txt | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/patch-compile-hbase-examples-jdk1.7.0_80.txt | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/whitespace-eol.txt | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/patch-findbugs-hbase-examples.txt | | javadoc | hbase-client-jdk1.8.0: https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/diff-javadoc-javadoc-hbase-client-jdk1.8.0.txt | | javadoc | hbase-server-jdk1.8.0: https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.8.0.txt | | javadoc | hbase-examples-jdk1.8.0: https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/diff-javadoc-javadoc-hbase-examples-jdk1.8.0.txt | | javadoc | hbase-client-jdk1.7.0_80: https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/diff-javadoc-javadoc-hbase-client-jdk1.7.0_80.txt | | javadoc | hbase-server-jdk1.7.0_80: https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.7.0_80.txt | | javadoc | hbase-examples-jdk1.7.0_80: https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/diff-javadoc-javadoc-hbase-examples-jdk1.7.0_80.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/patch-unit-hbase-client.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/patch-unit-hbase-server.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/patch-unit-hbase-examples.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/patch-unit-hbase-rest.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/patch-unit-hbase-client.txt https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/patch-unit-hbase-server.txt https://builds.apache.org/job/PreCommit-HBASE-Build/2774/artifact/patchprocess/patch-unit-hbase-rest.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/testReport/ | | modules | C: hbase-protocol hbase-common hbase-procedure hbase-client hbase-server hbase-rsgroup hbase-it hbase-examples hbase-rest hbase-spark U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/2774/console | | Powered by | Apache Yetus 0.2.1 http://yetus.apache.org | This message was automatically generated. > Shade protobuf > -------------- > > Key: HBASE-15638 > URL: https://issues.apache.org/jira/browse/HBASE-15638 > Project: HBase > Issue Type: Bug > Components: Protobufs > Reporter: stack > Assignee: stack > Priority: Critical > Attachments: 15638v2.patch, HBASE-15638.master.001.patch, > HBASE-15638.master.002.patch, HBASE-15638.master.003 (1).patch, > HBASE-15638.master.003 (1).patch, HBASE-15638.master.003 (1).patch, > HBASE-15638.master.003.patch, HBASE-15638.master.003.patch, > HBASE-15638.master.004.patch, HBASE-15638.master.005.patch, > HBASE-15638.master.006.patch, as.far.as.server.patch > > > Shade protobufs so we can move to a different version without breaking the > world. We want to get up on pb3 because it has unsafe methods that allow us > save on copies; it also has some means of dealing with BBs so we can pass it > offheap DBBs. We'll probably want to change PB3 to open it up some more too > so we can stay offheap as we traverse PB. This issue comes of [~anoop.hbase] > and [~ram_krish]'s offheaping of the readpath work. > This change is mostly straight-forward but there are some tricky bits: > # How to interface with HDFS? It wants its ByteStrings. Here in particular > in FanOutOneBlockAsyncDFSOutputSaslHelper: > {code} > if (payload != null) { > builder.setPayload(ByteString.copyFrom(payload)); > } > {code} > # [~busbey] also points out that we need to take care of endpoints done as > pb. Test at least. > Let me raise this one on the dev list too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)