[ https://issues.apache.org/jira/browse/HBASE-16272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404467#comment-15404467 ]
Hudson commented on HBASE-16272: -------------------------------- FAILURE: Integrated in HBase-0.98-matrix #379 (See [https://builds.apache.org/job/HBase-0.98-matrix/379/]) Revert "HBASE-16272 Overflow in ServerName's compareTo method (Huaxiang (apurtell: rev 6dfdc0d898b92371b8694ff4b32897ade8f53bcb) * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java HBASE-16272 Overflow in ServerName's compareTo method (Huaxiang Sun and (apurtell: rev e8a146a7845d3a6f86bba8f6dbee7c23054d8107) * hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/LongUtils.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java Amend HBASE-16272 Overflow in ServerName's compareTo method (apurtell: rev 92816613069df045495ae8fc5124224f98b5b390) * hbase-common/src/main/java/org/apache/hadoop/hbase/util/LongUtils.java > Overflow in ServerName's compareTo method > ----------------------------------------- > > Key: HBASE-16272 > URL: https://issues.apache.org/jira/browse/HBASE-16272 > Project: HBase > Issue Type: Bug > Components: hbase > Reporter: huaxiang sun > Assignee: huaxiang sun > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.1.6, 0.98.21, 1.2.3 > > Attachments: HBASE-16272-0.98-addendum.patch, HBASE-16272-0.98.patch, > HBASE-16272-v001.patch > > > Looking at the ServerName's compareTo(), > https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/ServerName.java#L303 > It converts the return int value by converting long to int like > (int)(longValue), which could be incorrect when it overflows, need to replace > it with Long.compareTo(a,b). > [~mbertozzi] found some others as well, such as > https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java#L990 -- This message was sent by Atlassian JIRA (v6.3.4#6332)