[ 
https://issues.apache.org/jira/browse/HBASE-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407055#comment-15407055
 ] 

Hadoop QA commented on HBASE-16308:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 30s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
56s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 29s 
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 22s 
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
49s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
24s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 
33s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 39s 
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 22s 
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
36s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 28s 
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 28s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 23s 
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 23s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
7s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
31m 44s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 12s 
{color} | {color:red} hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 
total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 25s 
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 22s 
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 46s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 58s {color} 
| {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 96m 7s {color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 11s 
{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 
10s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 173m 48s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-client |
|  |  Switch statement found in 
org.apache.hadoop.hbase.client.HBaseAdmin.getCompactionState(TableName, 
CompactType) where default case is missing  At HBaseAdmin.java:CompactType) 
where default case is missing  At HBaseAdmin.java:[lines 3040-3055] |
| Failed junit tests | hadoop.hbase.client.TestClientScanner |
|   | hadoop.hbase.security.visibility.TestWithDisabledAuthorization |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes |
|   | hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient |
|   | hadoop.hbase.TestNamespace |
|   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsOpWithDifferentUsersNoACL |
|   | hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove |
|   | hadoop.hbase.security.access.TestNamespaceCommands |
|   | hadoop.hbase.util.TestHBaseFsckTwoRS |
|   | hadoop.hbase.master.TestDistributedLogSplitting |
|   | 
hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString |
|   | hadoop.hbase.snapshot.TestSnapshotClientRetries |
|   | hadoop.hbase.master.TestAssignmentManagerOnCluster |
|   | hadoop.hbase.master.procedure.TestModifyNamespaceProcedure |
|   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService |
|   | hadoop.hbase.security.access.TestCellACLs |
|   | hadoop.hbase.snapshot.TestFlushSnapshotFromClient |
|   | hadoop.hbase.security.access.TestAccessController2 |
|   | hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure |
|   | hadoop.hbase.coprocessor.TestAggregateProtocol |
|   | hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL |
|   | hadoop.hbase.coprocessor.TestDoubleColumnInterpreter |
|   | hadoop.hbase.security.token.TestGenerateDelegationToken |
|   | hadoop.hbase.TestPartialResultsFromClientSide |
|   | hadoop.hbase.coprocessor.TestMasterObserver |
|   | hadoop.hbase.util.TestHBaseFsckReplicas |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsReplication |
|   | hadoop.hbase.coprocessor.TestBigDecimalColumnInterpreter |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack |
|   | hadoop.hbase.master.cleaner.TestSnapshotFromMaster |
|   | hadoop.hbase.master.TestRollingRestart |
|   | hadoop.hbase.security.visibility.TestVisibilityLablesWithGroups |
|   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService 
|
|   | hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator |
|   | hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient |
|   | hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint |
|   | hadoop.hbase.master.TestMasterRestartAfterDisablingTable |
|   | hadoop.hbase.master.TestHMasterRPCException |
|   | hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient |
|   | hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths |
|   | hadoop.hbase.master.procedure.TestCreateNamespaceProcedure |
|   | hadoop.hbase.coprocessor.TestCoprocessorEndpoint |
|   | hadoop.hbase.master.TestMasterFailover |
|   | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient |
|   | hadoop.hbase.master.TestMaster |
| Timed out junit tests | 
org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
|   | org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization |
|   | org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions |
|   | org.apache.hadoop.hbase.security.access.TestAccessController |
|   | org.apache.hadoop.hbase.ipc.TestRpcClientLeaks |
|   | org.apache.hadoop.hbase.util.TestHBaseFsckOneRS |
|   | org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas |
|   | 
org.apache.hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient
 |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12821937/HBASE-16308.master.004.patch
 |
| JIRA Issue | HBASE-16308 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 9b3bc5f |
| Default Java | 1.7.0_80 |
| Multi-JDK versions |  /usr/local/jenkins/java/jdk1.8.0:1.8.0 
/usr/local/asfpackages/java/jdk1.7.0_80:1.7.0_80 |
| findbugs | v3.0.0 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HBASE-Build/2922/artifact/patchprocess/new-findbugs-hbase-client.html
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/2922/artifact/patchprocess/patch-unit-hbase-client.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/2922/artifact/patchprocess/patch-unit-hbase-server.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-HBASE-Build/2922/artifact/patchprocess/patch-unit-hbase-client.txt
 
https://builds.apache.org/job/PreCommit-HBASE-Build/2922/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/2922/testReport/ |
| modules | C: hbase-common hbase-client hbase-server hbase-spark U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/2922/console |
| Powered by | Apache Yetus 0.2.1   http://yetus.apache.org |


This message was automatically generated.



> Contain protobuf references
> ---------------------------
>
>                 Key: HBASE-16308
>                 URL: https://issues.apache.org/jira/browse/HBASE-16308
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Protobufs
>            Reporter: stack
>            Assignee: stack
>         Attachments: HBASE-16308.master.001.patch, 
> HBASE-16308.master.002.patch, HBASE-16308.master.003.patch, 
> HBASE-16308.master.004.patch
>
>
> Clean up our protobuf references so contained to just a few classes rather 
> than being spread about the codebase. Doing this work will make it easier 
> landing the parent issue and will make it more clear where the division 
> between shaded protobuf and unshaded protobuf lies (we need to continue with 
> unshaded protobuf for HDFS references by AsyncWAL and probably EndPoint 
> Coprocessors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to