[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434148#comment-15434148
]
Hadoop QA commented on HBASE-16264:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 14m 10s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 78 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 3m 56s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
18s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 22s
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 24s
{color} | {color:green} master passed with JDK v1.7.0_111 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 29m
3s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 4m
14s {color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patched modules with no Java source: . {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 54s
{color} | {color:red} hbase-protocol in master has 93 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 33s
{color} | {color:red} hbase-rsgroup in master has 6 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 46s
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 49s
{color} | {color:green} master passed with JDK v1.7.0_111 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
54s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 24s
{color} | {color:red} root in the patch failed with JDK v1.8.0_101. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 24s {color} |
{color:red} root in the patch failed with JDK v1.8.0_101. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 24s {color}
| {color:red} root in the patch failed with JDK v1.8.0_101. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 27s
{color} | {color:red} root in the patch failed with JDK v1.7.0_111. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 27s {color} |
{color:red} root in the patch failed with JDK v1.7.0_111. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 27s {color}
| {color:red} root in the patch failed with JDK v1.7.0_111. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 35s {color}
| {color:red} hbase-server-jdk1.7.0_111 with JDK v1.7.0_111 generated 2 new + 4
unchanged - 2 fixed = 6 total (was 6) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 27m
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
37s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 4s
{color} | {color:red} The patch has 921 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 2s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 52s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patched modules with no Java source: . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
56s {color} | {color:green} hbase-protocol generated 0 new + 0 unchanged - 93
fixed = 0 total (was 93) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 2s
{color} | {color:red} hbase-common generated 2 new + 0 unchanged - 0 fixed = 2
total (was 0) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
15s {color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
40s {color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 18s
{color} | {color:red} hbase-client generated 6 new + 0 unchanged - 0 fixed = 6
total (was 0) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
42s {color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 51s
{color} | {color:red} hbase-rest generated 3 new + 0 unchanged - 0 fixed = 3
total (was 0) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
44s {color} | {color:green} hbase-rsgroup generated 0 new + 0 unchanged - 6
fixed = 0 total (was 6) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 18s
{color} | {color:red} hbase-server generated 8 new + 0 unchanged - 0 fixed = 8
total (was 0) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
57s {color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m 38s
{color} | {color:red} root-jdk1.8.0_101 with JDK v1.8.0_101 generated 1 new +
23 unchanged - 0 fixed = 24 total (was 23) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 25s
{color} | {color:red} hbase-server-jdk1.8.0_101 with JDK v1.8.0_101 generated 1
new + 4 unchanged - 0 fixed = 5 total (was 4) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 2m 25s
{color} | {color:red} root-jdk1.7.0_111 with JDK v1.7.0_111 generated 1 new +
29 unchanged - 0 fixed = 30 total (was 29) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 33s
{color} | {color:red} hbase-server-jdk1.7.0_111 with JDK v1.7.0_111 generated 1
new + 5 unchanged - 0 fixed = 6 total (was 5) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 22s
{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 42s
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 16s
{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 45s
{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 53s {color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 0s {color} |
{color:red} hbase-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 18s
{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 16s
{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 16s {color}
| {color:red} hbase-rest in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 19s
{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 25m 2s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 9s
{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
56s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 240m 8s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-common |
| | Possible null pointer dereference in
org.apache.hadoop.hbase.util.DynamicClassLoader.loadNewJars() due to return
value of called method Dereferenced at
DynamicClassLoader.java:org.apache.hadoop.hbase.util.DynamicClassLoader.loadNewJars()
due to return value of called method Dereferenced at
DynamicClassLoader.java:[line 183] |
| | Useless condition:a0 >= 241 (0xf1) at this point At
OrderedBytes.java:[line 466] |
| FindBugs | module:hbase-client |
| | org.apache.hadoop.hbase.HColumnDescriptor.getValues(boolean) makes
inefficient use of keySet iterator instead of entrySet iterator At
HColumnDescriptor.java:keySet iterator instead of entrySet iterator At
HColumnDescriptor.java:[line 997] |
| | Primitive is boxed to call
Integer.compareTo(Integer):Integer.compareTo(Integer): use Integer.compare(int,
int) instead At HTableDescriptor.java:[line 1076] |
| | org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl.TOKEN_HANDDLERS is a
mutable collection which should be package protected At
AsyncRpcChannelImpl.java:which should be package protected At
AsyncRpcChannelImpl.java:[line 87] |
| | org.apache.hadoop.hbase.ipc.RpcClientImpl.tokenHandlers is a mutable
collection which should be package protected At RpcClientImpl.java:which
should be package protected At RpcClientImpl.java:[line 125] |
| | Return value of org.apache.hadoop.hbase.ClusterStatus.getLoad(ServerName)
ignored, but method has no side effect At ProtobufUtil.java:but method has no
side effect At ProtobufUtil.java:[line 3300] |
| | Useless object stored in variable entries of method
org.apache.hadoop.hbase.util.PoolMap.entrySet() At PoolMap.java:entries of
method org.apache.hadoop.hbase.util.PoolMap.entrySet() At PoolMap.java:[line
188] |
| FindBugs | module:hbase-rest |
| | Useless object stored in variable restCsrfMethodsToIgnore of method
org.apache.hadoop.hbase.rest.RESTServer.addCSRFFilter(Context, Configuration)
At RESTServer.java:restCsrfMethodsToIgnore of method
org.apache.hadoop.hbase.rest.RESTServer.addCSRFFilter(Context, Configuration)
At RESTServer.java:[line 116] |
| |
org.apache.hadoop.hbase.rest.model.NamespacesInstanceModel.createProtobufOutput()
makes inefficient use of keySet iterator instead of entrySet iterator At
NamespacesInstanceModel.java:keySet iterator instead of entrySet iterator At
NamespacesInstanceModel.java:[line 151] |
| | org.apache.hadoop.hbase.rest.model.NamespacesInstanceModel.toString()
makes inefficient use of keySet iterator instead of entrySet iterator At
NamespacesInstanceModel.java:keySet iterator instead of entrySet iterator At
NamespacesInstanceModel.java:[line 136] |
| FindBugs | module:hbase-server |
| | Repeated conditional test in
org.apache.hadoop.hbase.LocalHBaseCluster.getActiveMaster() At
LocalHBaseCluster.java: At LocalHBaseCluster.java:[line 317] |
| | Primitive is boxed to call Long.compareTo(Long):Long.compareTo(Long): use
Long.compare(long, long) instead At Constraints.java:[line 616] |
| | Possible null pointer dereference in
org.apache.hadoop.hbase.mapreduce.JarFinder.zipDir(File, String,
ZipOutputStream, boolean) due to return value of called method Dereferenced at
JarFinder.java:org.apache.hadoop.hbase.mapreduce.JarFinder.zipDir(File, String,
ZipOutputStream, boolean) due to return value of called method Dereferenced at
JarFinder.java:[line 93] |
| | Useless condition:this.numProcessing >= 0 at this point At
DeadServer.java:[line 137] |
| | Primitive is boxed to call
Integer.compareTo(Integer):Integer.compareTo(Integer): use Integer.compare(int,
int) instead At BaseLoadBalancer.java:[line 779] |
| |
org.apache.hadoop.hbase.master.balancer.BaseLoadBalancer$Cluster$2.compare(Integer,
Integer) incorrectly handles float value At BaseLoadBalancer.java:value At
BaseLoadBalancer.java:[line 798] |
| | Return value of org.apache.hadoop.hbase.client.Mutation.getRow() ignored,
but method has no side effect At HRegion.java:but method has no side effect
At HRegion.java:[line 2686] |
| | Primitive is boxed to call Long.compareTo(Long):Long.compareTo(Long): use
Long.compare(long, long) instead At ReplicationSource.java:[line 456] |
| Failed junit tests | hadoop.hbase.ipc.TestCoprocessorRpcUtils |
| | hadoop.hbase.mob.mapreduce.TestMobSweepMapper |
| | hadoop.hbase.master.balancer.TestRegionLocationFinder |
| | hadoop.hbase.procedure.TestProcedureManager |
| | hadoop.hbase.rest.TestTableResource |
| | hadoop.hbase.rest.TestTableScan |
| | hadoop.hbase.rest.TestNamespacesInstanceResource |
| | hadoop.hbase.rest.TestScannersWithLabels |
| | hadoop.hbase.rest.TestResourceFilter |
| | hadoop.hbase.rest.TestDeleteRow |
| | hadoop.hbase.rest.TestVersionResource |
| | hadoop.hbase.rest.TestSchemaResource |
| | hadoop.hbase.rest.TestScannerResource |
| | hadoop.hbase.rest.TestGzipFilter |
| | hadoop.hbase.rest.TestNamespacesResource |
| | hadoop.hbase.rest.TestGetAndPutResource |
| | hadoop.hbase.rest.TestScannersWithFilters |
| | hadoop.hbase.rest.TestMultiRowResource |
| | hadoop.hbase.rest.client.TestRemoteTable |
| | hadoop.hbase.rest.TestStatusResource |
| | hadoop.hbase.TestInterfaceAudienceAnnotations |
| | hadoop.hbase.TestInterfaceAudienceAnnotations |
| | hadoop.hbase.rest.TestTableResource |
| | hadoop.hbase.rest.TestTableScan |
| | hadoop.hbase.rest.TestNamespacesInstanceResource |
| | hadoop.hbase.rest.TestScannersWithLabels |
| | hadoop.hbase.rest.TestResourceFilter |
| | hadoop.hbase.rest.TestDeleteRow |
| | hadoop.hbase.rest.TestVersionResource |
| | hadoop.hbase.rest.TestSchemaResource |
| | hadoop.hbase.rest.TestScannerResource |
| | hadoop.hbase.rest.TestGzipFilter |
| | hadoop.hbase.rest.TestNamespacesResource |
| | hadoop.hbase.rest.TestGetAndPutResource |
| | hadoop.hbase.rest.TestScannersWithFilters |
| | hadoop.hbase.rest.TestMultiRowResource |
| | hadoop.hbase.rest.client.TestRemoteTable |
| | hadoop.hbase.rest.TestStatusResource |
| | hadoop.hbase.ipc.TestCoprocessorRpcUtils |
| | hadoop.hbase.mob.mapreduce.TestMobSweepMapper |
| | hadoop.hbase.master.balancer.TestRegionLocationFinder |
| | hadoop.hbase.procedure.TestProcedureManager |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-08-23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12825160/HBASE-16264.master.003.patch
|
| JIRA Issue | HBASE-16264 |
| Optional Tests | asflicense findbugs xml javac javadoc unit compile
hadoopcheck hbaseanti checkstyle cc hbaseprotoc |
| uname | Linux d67772fd03cf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 91fee26 |
| Default Java | 1.7.0_111 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_101
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 |
| findbugs | v3.0.0 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/branch-findbugs-hbase-protocol-warnings.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/patch-compile-root-jdk1.8.0_101.txt
|
| cc |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/patch-compile-root-jdk1.8.0_101.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/patch-compile-root-jdk1.8.0_101.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt
|
| cc |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/diff-compile-javac-hbase-server-jdk1.7.0_111.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/whitespace-eol.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/new-findbugs-hbase-common.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/new-findbugs-hbase-client.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/new-findbugs-hbase-rest.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/new-findbugs-hbase-server.html
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/diff-javadoc-javadoc-root-jdk1.8.0_101.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.8.0_101.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/diff-javadoc-javadoc-root-jdk1.7.0_111.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.7.0_111.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/patch-unit-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/patch-unit-hbase-client.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/patch-unit-hbase-rest.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit test logs |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/patch-unit-root.txt
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/patch-unit-hbase-client.txt
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/patch-unit-hbase-rest.txt
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/testReport/ |
| modules | C: hbase-protocol hbase-common hbase-endpoint hbase-procedure .
hbase-client hbase-examples hbase-it hbase-rest hbase-rsgroup hbase-server
hbase-spark U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/3220/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Figure how to deal with endpoints and shaded pb
> -----------------------------------------------
>
> Key: HBASE-16264
> URL: https://issues.apache.org/jira/browse/HBASE-16264
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors, Protobufs
> Reporter: stack
> Assignee: stack
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-16264.master.001.patch,
> HBASE-16264.master.002.patch, HBASE-16264.master.003.patch
>
>
> Come up w/ a migration plan for coprocessor endpoints when our pb is shaded.
> Would be sweet if could make it so all just worked. At worst, come up w/ a
> prescription for how to migrate existing CPs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
