[ https://issues.apache.org/jira/browse/HBASE-16445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446614#comment-15446614 ]
Hadoop QA commented on HBASE-16445: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 16 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 17s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 3s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 24s {color} | {color:green} master passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 30s {color} | {color:green} master passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 10m 7s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 51s {color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 47s {color} | {color:red} hbase-protocol in master has 93 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s {color} | {color:green} master passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 9s {color} | {color:green} master passed with JDK v1.7.0_111 {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 44s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 18s {color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 18s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 18s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 28s {color} | {color:green} the patch passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 28s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 28s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 10m 2s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 51s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 27m 24s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 11s {color} | {color:red} hbase-protocol generated 6 new + 93 unchanged - 0 fixed = 99 total (was 93) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 17s {color} | {color:red} hbase-client generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 58s {color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 9s {color} | {color:green} the patch passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 21s {color} | {color:green} hbase-protocol in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 0s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 114m 8s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 23s {color} | {color:green} hbase-it in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 55s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 192m 59s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hbase-protocol | | | org.apache.hadoop.hbase.ipc.protobuf.generated.TestProtos$AddrResponseProto.PARSER isn't final but should be At TestProtos.java:be At TestProtos.java:[line 2261] | | | Class org.apache.hadoop.hbase.ipc.protobuf.generated.TestProtos$AddrResponseProto defines non-transient non-serializable instance field unknownFields In TestProtos.java:instance field unknownFields In TestProtos.java | | | Useless control flow in org.apache.hadoop.hbase.ipc.protobuf.generated.TestProtos$AddrResponseProto$Builder.maybeForceBuilderInitialization() At TestProtos.java: At TestProtos.java:[line 2500] | | | org.apache.hadoop.hbase.ipc.protobuf.generated.TestProtos$PauseRequestProto.PARSER isn't final but should be At TestProtos.java:be At TestProtos.java:[line 1814] | | | Class org.apache.hadoop.hbase.ipc.protobuf.generated.TestProtos$PauseRequestProto defines non-transient non-serializable instance field unknownFields In TestProtos.java:instance field unknownFields In TestProtos.java | | | Useless control flow in org.apache.hadoop.hbase.ipc.protobuf.generated.TestProtos$PauseRequestProto$Builder.maybeForceBuilderInitialization() At TestProtos.java: At TestProtos.java:[line 2026] | | FindBugs | module:hbase-client | | | Inconsistent synchronization of org.apache.hadoop.hbase.ipc.AsyncConnection.channel; locked 85% of time Unsynchronized access at AsyncConnection.java:85% of time Unsynchronized access at AsyncConnection.java:[line 203] | | | Inconsistent synchronization of org.apache.hadoop.hbase.ipc.Call.error; locked 40% of time Unsynchronized access at AbstractRpcClient.java:40% of time Unsynchronized access at AbstractRpcClient.java:[line 347] | | | Inconsistent synchronization of org.apache.hadoop.hbase.ipc.Call.response; locked 50% of time Unsynchronized access at AbstractRpcClient.java:50% of time Unsynchronized access at AbstractRpcClient.java:[line 354] | | Failed junit tests | hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData | | | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL | | | hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.security.token.TestTokenAuthentication | | | hadoop.hbase.replication.TestReplicationKillSlaveRS | | | hadoop.hbase.security.token.TestDelegationTokenWithEncryption | | | hadoop.hbase.security.visibility.TestVisibilityLabelsReplication | | | hadoop.hbase.security.visibility.TestVisibilityLabelsOpWithDifferentUsersNoACL | | | hadoop.hbase.regionserver.TestRegionReplicaFailover | | | hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths | | | hadoop.hbase.master.TestAssignmentManagerOnCluster | | | hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator | | | hadoop.hbase.master.TestMasterOperationsForRegionReplicas | | | hadoop.hbase.regionserver.TestRegionReplicas | | | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL | | | hadoop.hbase.security.token.TestGenerateDelegationToken | | | hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString | | | hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack | | | hadoop.hbase.replication.TestReplicationSyncUpTool | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes | | | hadoop.hbase.security.visibility.TestWithDisabledAuthorization | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService | | | hadoop.hbase.security.visibility.TestVisibilityLablesWithGroups | | | hadoop.hbase.regionserver.TestEncryptionKeyRotation | | | hadoop.hbase.master.procedure.TestServerCrashProcedure | | Timed out junit tests | org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoadWithOldSecureEndpoint | | | org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles | | | org.apache.hadoop.hbase.mapreduce.TestImportTSVWithTTLs | | | org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan1 | | | org.apache.hadoop.hbase.replication.TestSerialReplication | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-08-29 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12826015/HBASE-16445-v1.patch | | JIRA Issue | HBASE-16445 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc | | uname | Linux 62915d76dc7b 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | master / 950d547 | | Default Java | 1.7.0_111 | | Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 | | findbugs | v3.0.0 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/3312/artifact/patchprocess/branch-findbugs-hbase-protocol-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/3312/artifact/patchprocess/new-findbugs-hbase-protocol.html | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/3312/artifact/patchprocess/new-findbugs-hbase-client.html | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/3312/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/3312/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/3312/testReport/ | | modules | C: hbase-protocol hbase-client hbase-server hbase-it U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/3312/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Refactor and reimplement RpcClient > ---------------------------------- > > Key: HBASE-16445 > URL: https://issues.apache.org/jira/browse/HBASE-16445 > Project: HBase > Issue Type: Sub-task > Affects Versions: 2.0.0 > Reporter: Duo Zhang > Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-16445-v1.patch, HBASE-16445.patch > > > There are lots of common logics between RpcClientImpl and AsyncRpcClient. We > should have much less code comparing to the current implementations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)