[ 
https://issues.apache.org/jira/browse/HBASE-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447597#comment-15447597
 ] 

Hiroshi Ikeda commented on HBASE-16502:
---------------------------------------

Sorry for late response. The last patch seems good except the comment "rare 
case" is not true anymore:
{code}
         // rare case, but we need to handle arbitrary length of key
{code}

> Reduce garbage in BufferedDataBlockEncoder
> ------------------------------------------
>
>                 Key: HBASE-16502
>                 URL: https://issues.apache.org/jira/browse/HBASE-16502
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: binlijin
>            Assignee: binlijin
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-16502-master.patch, 
> HBASE-16502-master_addnum_v1.patch, HBASE-16502-master_v2.patch, 
> HBASE-16502.branch-1.v1.patch
>
>
> In BufferedDataBlockEncoder.SeekerState every read will new a tagsBuffer for  
> compressTags. There is no need when no tags or compressTags=false, so we can 
> reduce this new byte[] to reduce garbage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to