[ https://issues.apache.org/jira/browse/HBASE-15968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467256#comment-15467256 ]
Hadoop QA commented on HBASE-15968: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 2 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 5s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s {color} | {color:green} master passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s {color} | {color:green} master passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 49s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 27s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 56s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s {color} | {color:green} master passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s {color} | {color:green} master passed with JDK v1.7.0_111 {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 5s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 45s {color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 45s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s {color} | {color:green} the patch passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 53s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 48s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 28s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 27m 39s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 26s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 15s {color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s {color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s {color} | {color:green} the patch passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 0s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 31s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 65m 45s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hbase-server | | | Switch statement found in org.apache.hadoop.hbase.regionserver.querymatcher.MvccSensitiveTracker.add(Cell) where default case is missing At MvccSensitiveTracker.java:where default case is missing At MvccSensitiveTracker.java:[lines 172-188] | | Failed junit tests | hadoop.hbase.TestCheckTestClasses | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-09-06 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12827164/HBASE-15968-v1.patch | | JIRA Issue | HBASE-15968 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 06368276ee54 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / b6ba13c | | Default Java | 1.7.0_111 | | Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 | | findbugs | v3.0.0 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/3427/artifact/patchprocess/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/3427/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/3427/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/3427/testReport/ | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/3427/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > MVCC-sensitive semantics of versions > ------------------------------------ > > Key: HBASE-15968 > URL: https://issues.apache.org/jira/browse/HBASE-15968 > Project: HBase > Issue Type: New Feature > Reporter: Phil Yang > Assignee: Phil Yang > Attachments: HBASE-15968-v1.patch > > > In HBase book, we have a section in Versions called "Current Limitations" see > http://hbase.apache.org/book.html#_current_limitations > {quote} > 28.3. Current Limitations > 28.3.1. Deletes mask Puts > Deletes mask puts, even puts that happened after the delete was entered. See > HBASE-2256. Remember that a delete writes a tombstone, which only disappears > after then next major compaction has run. Suppose you do a delete of > everything ⇐ T. After this you do a new put with a timestamp ⇐ T. This put, > even if it happened after the delete, will be masked by the delete tombstone. > Performing the put will not fail, but when you do a get you will notice the > put did have no effect. It will start working again after the major > compaction has run. These issues should not be a problem if you use > always-increasing versions for new puts to a row. But they can occur even if > you do not care about time: just do delete and put immediately after each > other, and there is some chance they happen within the same millisecond. > 28.3.2. Major compactions change query results > …create three cell versions at t1, t2 and t3, with a maximum-versions > setting of 2. So when getting all versions, only the values at t2 and t3 will > be returned. But if you delete the version at t2 or t3, the one at t1 will > appear again. Obviously, once a major compaction has run, such behavior will > not be the case anymore… (See Garbage Collection in Bending time in HBase.) > {quote} > These limitations result from the current implementation on multi-versions: > we only consider timestamp, no matter when it comes; we will not remove old > version immediately if there are enough number of new versions. > So we can get a stronger semantics of versions by two guarantees: > 1, Delete will not mask Put that comes after it. > 2, If a version is masked by enough number of higher versions (VERSIONS in > cf's conf), it will never be seen any more. > Some examples for understanding: > (delete t<=3 means use Delete.addColumns to delete all versions whose ts is > not greater than 3, and delete t3 means use Delete.addColumn to delete the > version whose ts=3) > case 1: put t2 -> put t3 -> delete t<=3 -> put t1, and we will get t1 because > the put is after delete. > case 2: maxversion=2, put t1 -> put t2 -> put t3 -> delete t3, and we will > always get t2 no matter if there is a major compaction, because t1 is masked > when we put t3 so t1 will never be seen. > case 3: maxversion=2, put t1 -> put t2 -> put t3 -> delete t2 -> delete t3, > and we will get nothing. > case 4: maxversion=3, put t1 -> put t2 -> put t3 -> delete t2 -> delete t3, > and we will get t1 because it is not masked. > case 5: maxversion=2, put t1 -> put t2 -> put t3 -> delete t3 -> put t1, and > we can get t3+t1 because when we put t1 at second time it is the 2nd latest > version and it can be read. > case 6:maxversion=2, put t3->put t2->put t1, and we will get t3+t2 just like > what we can get now, ts is still the key of versions. > Different VERSIONS may result in different results even the size of result is > smaller than VERSIONS(see case 3 and 4). So Get/Scan.setMaxVersions will be > handled at end after we read correct data according to CF's VERSIONS setting. > The semantics is different from the current HBase, and we may need more logic > to support the new semantic, so it is configurable and default is disabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)