[ https://issues.apache.org/jira/browse/HBASE-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15483734#comment-15483734 ]
Anoop Sam John commented on HBASE-16612: ---------------------------------------- JMH shows ~3x gain with arrays? That is good.. This usage is there in hot code paths.. Lets get this in for trunk > Use array to cache Types for KeyValue.Type.codeToType > ----------------------------------------------------- > > Key: HBASE-16612 > URL: https://issues.apache.org/jira/browse/HBASE-16612 > Project: HBase > Issue Type: Bug > Affects Versions: 1.1.6, 1.2.3, 0.98.22 > Reporter: Phil Yang > Assignee: Phil Yang > Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16612-v1.patch > > > We don't rely on enum ordinals in KeyValye.Type. We have own code in it. In > codeToType, we use a loop to find the Type which is not a good idea. We can > just use an arryay[256] to cache all types. -- This message was sent by Atlassian JIRA (v6.3.4#6332)