[
https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15489260#comment-15489260
]
Charlie Qiangeng Xu commented on HBASE-16626:
---------------------------------------------
Thank you [~tedyu] for adding me!
Just added a empty implementation default method in Interface RegionScanner.
Or maybe should I add this to Interface Shipper so that the patch could cover
more sub scanner interfaces?
One concern would be, if added to Interface Shipper, the user extending e.g.
Interface KeyValueScanner(one that also extends Shipper)
might forget to create their shipped function to invoke returnBlockToCache.
Any thought [~anoop.hbase]?
> User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap
> part
> ---------------------------------------------------------------------------------
>
> Key: HBASE-16626
> URL: https://issues.apache.org/jira/browse/HBASE-16626
> Project: HBase
> Issue Type: Sub-task
> Components: Offheaping
> Affects Versions: 1.2.2, 1.1.6
> Reporter: Charlie Qiangeng Xu
> Assignee: Charlie Qiangeng Xu
> Fix For: 2.0.0
>
>
> Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a
> new interface Shipper which contains a "shipped()" method.
> In our case, some application user defined customized scanner that implements
> Interface RegionScanner in 1.X .
> After we back ported the Off Heap feature of 2.0.0,
> RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when
> executing scanner.shipped(). It is because the customized scanner didn't
> override the shipped method yet.
> Instead of forcing every user to add a empty implementation(if they don't
> really need to scan the file or the RS don't use L2 cache, they don't need to
> do anything in shipped method) , adding a default method of shipped in
> Interface RegionScanner might be a better way.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
