[ 
https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490827#comment-15490827
 ] 

stack commented on HBASE-16631:
-------------------------------

Is this a straight extraction or did you make other changes? If so, patch LGTM. 
We'll probably want to change our Future to subclass CompletableFuture but that 
can come later. I like that you keep the implementations package private.

> Extract AsyncRequestFuture related code from AsyncProcess
> ---------------------------------------------------------
>
>                 Key: HBASE-16631
>                 URL: https://issues.apache.org/jira/browse/HBASE-16631
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Heng Chen
>            Assignee: Heng Chen
>         Attachments: HBASE-16631.v1.patch, HBASE-16631.wip.patch
>
>
> Now, AsyncProcess class is too large (over 2000+ lines),  and there are so 
> many sub classes in it.  
> AsyncRequestFutureImpl is the biggest subclass in AP,  we could extract it 
> out from AP to reduce the AP size.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to