[ 
https://issues.apache.org/jira/browse/HBASE-15523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496759#comment-15496759
 ] 

Jerry He commented on HBASE-15523:
----------------------------------

Yes. autorestart is supported in hbase-daemon.sh.
hbase-daemon.sh  start|stop|restart|autorestart

I think the argument is that 'autorestart' is behavior option or extension for 
the operation 'start'.  It is better and more flexible to control this behavior 
option via other means, instead of having a separate command.
In the Ambari case, even it were going to be built into Ambari, for a user to 
be able to control and switch dynamically on the Ambari console, it probably 
still need a dynamic switch on the console, and either 'start' or 'autorestart' 
is invoked based on the switch.
Then why not have this dynamic switch in HBase?
We can introduce this env property, and deprecate the ''autorestart' command.

My two cents.

> enhance hbase-daemon.sh to enable autorestart.
> ----------------------------------------------
>
>                 Key: HBASE-15523
>                 URL: https://issues.apache.org/jira/browse/HBASE-15523
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Yi Liang
>            Assignee: Yi Liang
>            Priority: Minor
>         Attachments: HBASE-15523.patch
>
>
> enhance hbase-daemon.sh to enable autorestart.
> component(like master, region server) will auto-start when terminated/killed 
> abnormally if 
>            (a) Add a new env variable $HBASE_AUTORESTART to hbase-env.sh i.e. 
>          export HBASE_AUTORESTART=true
>           (b) Then add the following 3 simple lines(59-61) to  
> /bin/hbase-daemon.sh
>      
>      51 # get arguments
>      52 startStop=$1
>      53 shift
>      54
>      55 command=$1
>      56 shift
>      57
>      58 #make sure the auto-restart are default settings
>      59 if [ "$HBASE_AUTORESTART" == "true" ] && [ "$startStop" == "start" ]; 
> then     
>      60   startStop="autorestart"     
>      61 fi



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to