[
https://issues.apache.org/jira/browse/HBASE-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162610#comment-13162610
]
Phabricator commented on HBASE-4908:
------------------------------------
mbautin has commented on the revision "[jira] [HBASE-4908] HBase cluster test
tool (port from 0.89-fb)".
@stack: see responses to your comments inline. A new version of the diff will
follow.
INLINE COMMENTS
src/test/java/org/apache/hadoop/hbase/manual/HBaseClusterTest.java:47 Added
class documentation.
src/test/java/org/apache/hadoop/hbase/manual/HBaseClusterTest.java:52 Removed
trailing underscores.
src/test/java/org/apache/hadoop/hbase/manual/HBaseClusterTest.java:275 I
added some class comment anyway, and removed kill test and append test from
this tool (we can port them over separately).
src/test/java/org/apache/hadoop/hbase/manual/utils/HBaseUtils.java:38 Moved
these tool methods to Keying and HBaseTestingUtility and got rid of this class.
src/test/java/org/apache/hadoop/hbase/manual/utils/HBaseUtils.java:53 Got rid
of this method entirely and started using the HTable constructor directly.
src/test/java/org/apache/hadoop/hbase/manual/utils/HBaseUtils.java:54 See
above (got rid of this method).
src/test/java/org/apache/hadoop/hbase/manual/utils/HBaseUtils.java:59 Moved
this to HBaseTestingUtility.
src/test/java/org/apache/hadoop/hbase/manual/utils/HBaseUtils.java:92 Changed
to "getMetaRSPort" (because we only need the port number in this use case) and
modified to use getRegionLocation.
src/test/java/org/apache/hadoop/hbase/manual/utils/HBaseUtils.java:96 See the
above comment.
src/test/java/org/apache/hadoop/hbase/manual/utils/HBaseUtils.java:99 Got rid
of this method.
src/test/java/org/apache/hadoop/hbase/manual/utils/HBaseUtils.java:111 Moved
to Keying. Not sure where HBaseSplitter is (could not find that type or file).
src/test/java/org/apache/hadoop/hbase/manual/utils/HBaseUtils.java:124 Moved
to Keying.
src/test/java/org/apache/hadoop/hbase/manual/utils/HBaseUtils.java:139 Moved
to Bytes.
src/test/java/org/apache/hadoop/hbase/manual/utils/HBaseUtils.java:151 Moved
to Bytes.
src/test/java/org/apache/hadoop/hbase/manual/utils/HdfsAppender.java:36
Removed HdfsAppender from this diff.
src/test/java/org/apache/hadoop/hbase/manual/utils/KillProcessesAndVerify.java:33
Removed the kill test from this diff.
src/test/java/org/apache/hadoop/hbase/manual/utils/KillProcessesAndVerify.java:119
Removed this entire class from the diff for now.
src/test/java/org/apache/hadoop/hbase/manual/utils/KillProcessesAndVerify.java:152
Removed this entire class (kill test) for now.
src/test/java/org/apache/hadoop/hbase/manual/utils/MultiThreadedAction.java:31
Added.
src/test/java/org/apache/hadoop/hbase/manual/utils/MultiThreadedActionMBean.java:19
Removed this class. Its only purpose was to collect stats from the distributed
load test through JMX.
src/test/java/org/apache/hadoop/hbase/manual/utils/ProcessBasedLocalHBaseCluster.java:36
Added a class comment. Unlike MiniHBaseCluster, this starts each daemon as a
separate process and allows to do real kill testing.
src/test/java/org/apache/hadoop/hbase/manual/utils/ProcessBasedLocalHBaseCluster.java:256
Refactored this to generate configuration from a map. Does that address your
concern, or are you objecting to the whole idea of auto-generating
configuration for daemon processes in a process-based local HBase cluster?
REVISION DETAIL
https://reviews.facebook.net/D549
> HBase cluster test tool (port from 0.89-fb)
> -------------------------------------------
>
> Key: HBASE-4908
> URL: https://issues.apache.org/jira/browse/HBASE-4908
> Project: HBase
> Issue Type: Sub-task
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: D549.1.patch, D549.2.patch, D549.3.patch, D549.4.patch
>
>
> Porting one of our HBase cluster test tools (a single-process multi-threaded
> load generator and verifier) from 0.89-fb to trunk.
> I cleaned up the code a bit compared to what's in 0.89-fb, and discovered
> that it has some features that I have not tried yet (some kind of a kill
> test, and some way to run HBase as multiple processes on one machine).
> The main utility of this piece of code for us has been the HBaseClusterTest
> command-line tool (called HBaseTest in 0.89-fb), which we usually invoke as a
> load test in our five-node dev cluster testing, e.g.:
> hbase org.apache.hadoop.hbase.manual.HBaseTest -load 1000000000:50:100:20 -tn
> load_test -read 1:1000000000:50:20 -zk <zk_quorum> -bloom ROWCOL -compression
> GZIP
> I will be using this code to load-test the delta encoding patch and making
> fixes, but I am submitting the patch for early feedback. I will probably try
> out its other functionality and comment on how it works.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
