[ 
https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516021#comment-15516021
 ] 

Anoop Sam John commented on HBASE-16665:
----------------------------------------

bq. family, 0, family == null ? 0 : (byte)family.length,
So family being null was the test issue?  Is it ok to pass null as family 
array?  getFamilyArray would return null then.  Do we need to pass empty 
byte[]?  It might be ok as check length before using the getxxxArray().  Still 
for correctness can pass EMPTY byte[].
{code}
if(family == null) family  = HConstants.EMPTY_BYTE_ARRAY;
// for qual also.
{code}
WDYT?

> Check whether KeyValueUtil.createXXX could be replaced by CellUtil without 
> copy
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-16665
>                 URL: https://issues.apache.org/jira/browse/HBASE-16665
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Heng Chen
>         Attachments: HBASE-16665.patch, HBASE-16665.v1.patch, 
> HBASE-16665.v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to